From: Jiri Benc <jbenc@suse.cz>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>,
linville@tuxdriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface.
Date: Thu, 20 Jul 2006 10:54:42 +0200 [thread overview]
Message-ID: <20060720105442.23fc9960@griffin.suse.cz> (raw)
In-Reply-To: <200607191807.12360.flamingice@sourmilk.net>
On Wed, 19 Jul 2006 18:07:05 -0700, Michael Wu wrote:
> Why is that? Isn't there a BSSID in AP mode too? Perhaps it is calling
> config_interface before setting the BSSID?
The bssid field in ieee80211_if_conf structure is not set in AP mode.
There is no need for that - you already have a MAC address of the AP
interface (from add_interface callback). That's your BSSID.
> adm8211 doesn't support AP mode yet, but it's good to know this crash won't
> occur when it does. :)
The crash won't occur even without the patch - you will need to do
completely different things in adm8211_config_interface for AP mode than
for STA or IBSS mode and you will put some switch there anyway. No
reason for doing it now and bloating the code with a check for condition
that cannot happen.
Thanks,
Jiri
--
Jiri Benc
SUSE Labs
next prev parent reply other threads:[~2006-07-20 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 20:26 [PATCH] drivers/net/wireless/d80211: Check configuration type in hw->config_interface Jean-Mickael Guerin
2006-07-19 21:13 ` Ivo Van Doorn
2006-07-19 22:05 ` Jean-Mickael Guerin
2006-07-20 1:07 ` [PATCH] " Michael Wu
2006-07-20 8:54 ` Jiri Benc [this message]
2006-07-20 8:46 ` Jiri Benc
2006-07-20 16:19 ` Ivo Van Doorn
2006-07-20 16:47 ` Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060720105442.23fc9960@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=flamingice@sourmilk.net \
--cc=jean-mickael.guerin@6wind.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).