netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olh@suse.de>
To: Michael Buesch <mb@bu3sch.de>
Cc: Jason Lunz <lunz@falooley.org>, netdev@vger.kernel.org
Subject: Re: incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo
Date: Fri, 21 Jul 2006 21:12:24 +0200	[thread overview]
Message-ID: <20060721191224.GA7685@suse.de> (raw)
In-Reply-To: <200607212103.23954.mb@bu3sch.de>

 On Fri, Jul 21, Michael Buesch wrote:

> On Friday 21 July 2006 20:59, Olaf Hering wrote:
> > 
> > bcm43xx_get_drvinfo in 2.6.18-rc2 unfortunately uses UTS_RELEASE as
> > driver version. I think this specific info can be obtained by other
> > ways.
> > Can you give bcm43xx a real version number and provide it via the
> > ethtool ioctl?
> 
> I am not going to maintain a bogus version number.
> What about simply returning 1.0 and be done with it.
> I don't think it matters. 1.0 is as bogus as any other value.

I'm less concerned about the actual number, just UTS_RELEASE should
disappear, and the #include.

  reply	other threads:[~2006-07-21 19:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-21 18:59 incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo Olaf Hering
2006-07-21 19:03 ` Michael Buesch
2006-07-21 19:12   ` Olaf Hering [this message]
2006-07-21 19:13   ` Jason Lunz
2006-07-21 19:27     ` Michael Buesch
2006-07-21 20:05       ` Jason Lunz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060721191224.GA7685@suse.de \
    --to=olh@suse.de \
    --cc=lunz@falooley.org \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).