netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Jason Lunz <lunz@falooley.org>
Cc: Olaf Hering <olh@suse.de>, netdev@vger.kernel.org
Subject: Re: incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo
Date: Fri, 21 Jul 2006 21:27:23 +0200	[thread overview]
Message-ID: <200607212127.23786.mb@bu3sch.de> (raw)
In-Reply-To: <20060721191329.GA15478@knob.reflex>

On Friday 21 July 2006 21:13, Jason Lunz wrote:
> On Fri, Jul 21, 2006 at 09:03:23PM +0200, Michael Buesch wrote:
> > I am not going to maintain a bogus version number.
> > What about simply returning 1.0 and be done with it.
> > I don't think it matters. 1.0 is as bogus as any other value.
> 
> Put it to use! Increment it whenever there's a major change in the

What is a major change? Why only on major change? Why not on
simple changes, too? Simple changes sometimes introduce bugs, too.

> driver, like the locking rewrite or the init routine rewrite. At the
> very least, it makes it easier to rule certain things out if a user
> reports lockup or something.

What I wanted to say: I _never_ had debugging-problems, because
I did not know the source state it was compiled from.

If there is a lockup, and I don't see if a specific change
that might cause it is in or not, I simply ask him. It's _much_
easier than maintaining a bogus counter.

The version counter will cause patch hunks to fail and whatever.
It's only useless trouble.

If someone is not able to answer questions like:
"Which kernel version do you run?"
"Please look at foo.c line 234 and tell me what's there."
He does not want to debug the problem anyway. Problem solved.
Someone else will appear to help debugging it, if it's a real bug.

-- 
Greetings Michael.

  reply	other threads:[~2006-07-21 19:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-21 18:59 incorrect usage of UTS_RELEASE in bcm43xx_get_drvinfo Olaf Hering
2006-07-21 19:03 ` Michael Buesch
2006-07-21 19:12   ` Olaf Hering
2006-07-21 19:13   ` Jason Lunz
2006-07-21 19:27     ` Michael Buesch [this message]
2006-07-21 20:05       ` Jason Lunz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607212127.23786.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=lunz@falooley.org \
    --cc=netdev@vger.kernel.org \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).