[PATCH] mark sk98lin driver for removal

[PATCH] mark sk98lin driver for removal

[Stephen Hemminger]

The sk98lin driver is now superseded by the skge driver. I wanted to just
let the old driver wither and die from old age, but there are still bugs
that are too painful to fix.

See http://bugzilla.kernel.org/show_bug.cgi?id=6780
The board crashes repeatedly after 2 weeks. It probably is something
in the vendor MIB code. That code is a mess, and starting over was one
of the motivations for creating the skge driver.

So rather than add more bondo to the old beater to cover the rusty bits,
throw it in the dustbin.

Signed-off-by: Stephen Hemminger <shemminger@osdl.or

--- skge.orig/Documentation/feature-removal-schedule.txt
+++ skge/Documentation/feature-removal-schedule.txt
@@ -258,3 +258,10 @@ Why:	These drivers never compiled since 
 Who:	Jean Delvare <khali@linux-fr.org>
 
 ---------------------------
+
+What:   sk98lin network driver
+When:   January 2007
+Why:    replaced by the skge driver
+Who:    Stephen Hemminger <shemminger@osdl.org>
+
+---------------------------
--- skge.orig/MAINTAINERS
+++ skge/MAINTAINERS
@@ -2677,6 +2677,10 @@ L:	sdhci-devel@list.drzeus.cx
 W:	http://mmc.drzeus.cx/wiki/Linux/Drivers/sdhci
 S:	Maintained
 
+SK98LIN GIGABBIT ETHERNET DRIVER
+L:	netdev@vger.kernel.org
+S:	Obsolete
+
 SKGE, SKY2 10/100/1000 GIGABIT ETHERNET DRIVERS
 P:	Stephen Hemminger
 M:	shemminger@osdl.org

Re: [PATCH] mark sk98lin driver for removal

[Dave Jones]

On Sat, Jul 22, 2006 at 02:11:50PM -0700, Stephen Hemminger wrote:
 > The sk98lin driver is now superseded by the skge driver. I wanted to just
 > let the old driver wither and die from old age, but there are still bugs
 > that are too painful to fix.
 > 
 > See http://bugzilla.kernel.org/show_bug.cgi?id=6780
 > The board crashes repeatedly after 2 weeks. It probably is something
 > in the vendor MIB code. That code is a mess, and starting over was one
 > of the motivations for creating the skge driver.
 > 
 > So rather than add more bondo to the old beater to cover the rusty bits,
 > throw it in the dustbin.
 > 
 > Signed-off-by: Stephen Hemminger <shemminger@osdl.or

After a huge number of bug reports in Fedora 'went away' when we
switched our users to using skge instead, I wholeheartedly endorse this.
sk98lin is a disaster.  The last time I looked the vendor out-of-tree
driver had a huge delta vs mainline, and backed out numerous fixes
made to it in the mainline kernel. It's a huge effort to get the 'good bits'
out of that patch, and letting it die is the only sensible solution IMO.

ACKed-by: Dave Jones <davej@redhat.com>


 > +SK98LIN GIGABBIT ETHERNET DRIVER

typo :-)

		Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH] mark sk98lin driver for removal

[John W. Linville]

On Sat, Jul 22, 2006 at 07:17:03PM -0400, Dave Jones wrote:
> On Sat, Jul 22, 2006 at 02:11:50PM -0700, Stephen Hemminger wrote:
>  > The sk98lin driver is now superseded by the skge driver. I wanted to just
>  > let the old driver wither and die from old age, but there are still bugs
>  > that are too painful to fix.

>  > So rather than add more bondo to the old beater to cover the rusty bits,
>  > throw it in the dustbin.
>  > 
>  > Signed-off-by: Stephen Hemminger <shemminger@osdl.or
> 
> After a huge number of bug reports in Fedora 'went away' when we
> switched our users to using skge instead, I wholeheartedly endorse this.

> ACKed-by: Dave Jones <davej@redhat.com>

ACKed-by: John W. Linville <linville@tuxdriver.com>

-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH] mark sk98lin driver for removal

[Jeff Garzik]

ACK, however

[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.

Applying 'mark sk98lin driver for removal'

error: patch failed: Documentation/feature-removal-schedule.txt:258
error: Documentation/feature-removal-schedule.txt: patch does not apply

Re: [PATCH] mark sk98lin driver for removal

[Michael Stone]

Hopefully the skge driver will be updated to support everything the 
sk98lin driver does before it is removed. Among other things, I don't 
see any documentation for the skge driver similar to that for the 
sk98lin driver. Is there some driver option to use both ports of a dual 
port card, as there was for the sk98lin module?

I tried testing the skge driver on one system and got this in dmesg:

skge 0000:03:0c.0: unsupported phy type 0x0
ACPI: PCI interrupt for device 0000:03:0c.0 disabled
skge: probe of 0000:03:0c.0 failed with error -95

the sk98lin driver says:

eth0: SysKonnect SK-NET Gigabit Ethernet Adapter SK-9843 SX
      PrefPort:A  RlmtMode:Check Link State

Mike Stone

Re: [PATCH] mark sk98lin driver for removal

[Stephen Hemminger]

On Tue, 15 Aug 2006 09:18:54 -0400
Michael Stone <mstone@mathom.us> wrote:

> Hopefully the skge driver will be updated to support everything the 
> sk98lin driver does before it is removed. Among other things, I don't 
> see any documentation for the skge driver similar to that for the 
> sk98lin driver.

I don't see any need for additional documentation.
What is in sk98lin:
	* installation	--> already covered by normal kernel install
	* compiling	--> ditto
	* loading module --> ditto
	* driver parameters 
		skge/sky2 don't have many and most are standard across other drivers
		This driver intentionally does not support configuration via module
		parameters because it is better done through ethtool
			

> Is there some driver option to use both ports of a dual 
> port card, as there was for the sk98lin module?

The driver has always supported both ports as separate devices. If you want to
use bonding or fail over that is available in generic kernel.

> I tried testing the skge driver on one system and got this in dmesg:
> 
> skge 0000:03:0c.0: unsupported phy type 0x0
> ACPI: PCI interrupt for device 0000:03:0c.0 disabled
> skge: probe of 0000:03:0c.0 failed with error -95
>

What hardware was that? Please send me an lspci -vv output.
I can add support for it. I avoided adding support for all the possible
flavors because some of the variants seem to only have existed on a test bench.

> the sk98lin driver says:
> 
> eth0: SysKonnect SK-NET Gigabit Ethernet Adapter SK-9843 SX
>       PrefPort:A  RlmtMode:Check Link State
> 
> Mike Stone

Re: [PATCH] mark sk98lin driver for removal

[Michael Stone]

On Tue, Aug 15, 2006 at 11:03:40AM -0700, Stephen Hemminger wrote:
>	* driver parameters 
>		skge/sky2 don't have many and most are standard across other drivers
>		This driver intentionally does not support configuration via module
>		parameters because it is better done through ethtool

Fair enough. It might be nice to mention that specifically somewhere, for 
people transitioning from sk98lin (which required a special parameter in 
order to use both ports).

>The driver has always supported both ports as separate devices. If you want to
>use bonding or fail over that is available in generic kernel.

ok, I'll test that in the next few days.

>> I tried testing the skge driver on one system and got this in dmesg:
>> 
>> skge 0000:03:0c.0: unsupported phy type 0x0
>> ACPI: PCI interrupt for device 0000:03:0c.0 disabled
>> skge: probe of 0000:03:0c.0 failed with error -95
>>
>
>What hardware was that? Please send me an lspci -vv output.

0000:03:0c.0 Ethernet controller: Syskonnect (Schneider & Koch) SK-98xx Gigabit Ethernet Server Adapter (rev 12)
        Subsystem: Syskonnect (Schneider & Koch) SK-9843 Gigabit Ethernet Server Adapter (SK-NET GE-SX)
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
        Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Latency: 32 (5750ns min, 7750ns max), Cache Line Size: 0x10 (64 bytes)
        Interrupt: pin A routed to IRQ 21
        Region 0: Memory at dfddc000 (32-bit, non-prefetchable) [size=16K]
        Region 1: I/O ports at e800 [size=256]
        Expansion ROM at d8000000 [disabled] [size=128K]
        Capabilities: [48] Power Management version 1
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=1 PME-
        Capabilities: [50] Vital Product Data

Mike Stone

Re: [PATCH] mark sk98lin driver for removal

[Michael Stone]

On Tue, Aug 15, 2006 at 02:42:32PM -0400, Michael Stone wrote:
>On Tue, Aug 15, 2006 at 11:03:40AM -0700, Stephen Hemminger wrote:
>>The driver has always supported both ports as separate devices. If you 
>>want to
>>use bonding or fail over that is available in generic kernel.
>
>ok, I'll test that in the next few days.

The testing didn't get far; the SK-9844 isn't supported either (same 
"unsupported phy" message). 

0000:01:06.0 Ethernet controller: Syskonnect (Schneider & Koch) SK-98xx Gigabit Ethernet Server Adapter (rev 12)
        Subsystem: Syskonnect (Schneider & Koch) SK-9844 Gigabit Ethernet Server Adapter (SK-NET GE-SX dual link)
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
        Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
        Latency: 32 (5750ns min, 7750ns max), Cache Line Size: 0x10 (64 bytes)
        Interrupt: pin A routed to IRQ 20
        Region 0: Memory at fcf04000 (32-bit, non-prefetchable) [size=16K]
        Region 1: I/O ports at dc00 [size=256]
        Expansion ROM at fce00000 [disabled] [size=128K]
        Capabilities: [48] Power Management version 1
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=1 PME-
        Capabilities: [50] Vital Product Data


-- 
Michael Stone