From: David Miller <davem@davemloft.net>
To: yjwei@nanjing-fnst.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] SNMPv2 tcpAttemptFails counter error
Date: Mon, 24 Jul 2006 14:22:01 -0700 (PDT) [thread overview]
Message-ID: <20060724.142201.27783219.davem@davemloft.net> (raw)
In-Reply-To: <1152091195.3866.4.camel@LINE>
From: Wei Yongjun <yjwei@nanjing-fnst.com>
Date: Wed, 05 Jul 2006 05:19:54 -0400
> In my test, those direct state transition can not be counted to
> tcpAttemptFails. Following is my patch:
>
> Signed-off-by: Wei Yongjun <yjwei@nanjing-fnst.com>
This change can be implemented more simply, I believe.
Except for the tcp_minisocks.c change, all the paths
changed go to tcp_done() which is what actually transfers
the state to TCP_CLOSE. Therefore, tcp_done() can
simply be modified to check if the current state is
TCP_SYN_RECV, and is so bump the counter.
Once you implement it this way, please audit all call paths
to make sure we don't now bump this counter twice.
Thank you.
next prev parent reply other threads:[~2006-07-24 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 9:19 [PATCH] SNMPv2 tcpAttemptFails counter error Wei Yongjun
2006-07-24 21:22 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-28 11:40 Wei Yongjun
2006-07-31 3:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724.142201.27783219.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yjwei@nanjing-fnst.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).