From: Christoph Hellwig <hch@infradead.org>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linville@tuxdriver.com, Jiri Benc <jbenc@suse.cz>,
netdev@vger.kernel.org, proski@gnu.org
Subject: Re: [PATCH wireless-dev 2/5] orinoco: Switch to d80211.h
Date: Mon, 24 Jul 2006 05:03:55 +0100 [thread overview]
Message-ID: <20060724040355.GA6823@infradead.org> (raw)
In-Reply-To: <200607232040.37823.flamingice@sourmilk.net>
On Sun, Jul 23, 2006 at 08:40:20PM -0700, Michael Wu wrote:
> orinoco: Switch to d80211.h
>
> This patch "converts" the orinoco driver to use d80211.h instead of
> ieee80211.h. It also copies the IEEE80211_DATA_LEN definition to
> d80211.h for use by the stack and drivers.
NACK for all of these patches. The names in ieee80211.h
a) make a whole lot more sense
b) are used all over the kernel already
please convert the devicescape stack to reuse existing infrastrucure instead,
and that starts with things as simple as names for constants and data
structures in headers.
next prev parent reply other threads:[~2006-07-24 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 3:40 [PATCH wireless-dev 2/5] orinoco: Switch to d80211.h Michael Wu
2006-07-24 4:01 ` Jeff Garzik
2006-07-24 4:03 ` Christoph Hellwig [this message]
2006-07-24 4:06 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724040355.GA6823@infradead.org \
--to=hch@infradead.org \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).