public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@suse.cz>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linville@tuxdriver.com, Michael Buesch <mb@bu3sch.de>,
	netdev@vger.kernel.org
Subject: Re: [PATCH wireless-dev] d80211: Make MACSTR/MAC2STR macro available to drivers
Date: Mon, 24 Jul 2006 15:54:35 +0200	[thread overview]
Message-ID: <20060724155435.6ec32485@griffin.suse.cz> (raw)
In-Reply-To: <200607230143.31375.flamingice@sourmilk.net>

On Sun, 23 Jul 2006 01:43:25 -0700, Michael Wu wrote:
> This patch moves the MACSTR/MAC2STR macros to d80211.h
> so that they are available to drivers. It also converts the adm8211
> and bcm43xx drivers to use this macro.

I really dislike those MACSTR/MAC2STR names. I always fail to remember
which one is which. What about renaming them when we are touching them?

And why not to use MAC_FMT/MAC_ARG names as used in net/ieee80211.h? ;-)

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs

  parent reply	other threads:[~2006-07-24 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-23  8:43 [PATCH wireless-dev] d80211: Make MACSTR/MAC2STR macro available to drivers Michael Wu
2006-07-23  9:10 ` Michael Buesch
2006-07-23  9:31   ` Michael Wu
2006-07-24 13:54 ` Jiri Benc [this message]
2006-07-24 16:40   ` Michael Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060724155435.6ec32485@griffin.suse.cz \
    --to=jbenc@suse.cz \
    --cc=flamingice@sourmilk.net \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox