From: Michael Wu <flamingice@sourmilk.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: netdev@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names
Date: Wed, 26 Jul 2006 09:43:55 -0700 [thread overview]
Message-ID: <200607260944.01692.flamingice@sourmilk.net> (raw)
In-Reply-To: <20060726183200.79fb431e@griffin.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Wednesday 26 July 2006 09:32, Jiri Benc wrote:
> One more thing (hopefully the last one), could you try to keep lines
> under 80 characters? I understand that with such long identifiers it is
> not always possible (it dramatically reduces readability of the code if
> you try to force the limit in every case) but there are some places
> where it is feasible.
>
Ah, yeah, that was a problem..
> Also, when changing a line that is indented with spaces instead of tab
> characters, it's nice to convert that spaces to tabs. That's not a
> requirement, though; I will modify the patch if you won't do it.
>
I still want to convert d80211_mgmt.h. Once that's done, I'll look through for
those tabs/spaces & long lines formatting issues. I won't mind if you start
fixing some of those issues now, however. :)
-Michael Wu
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-07-26 16:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 6:02 [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names Michael Wu
2006-07-26 16:32 ` Jiri Benc
2006-07-26 16:43 ` Michael Wu [this message]
2006-07-26 16:53 ` Jiri Benc
2006-07-26 17:10 ` Michael Wu
-- strict thread matches above, loose matches on Subject: below --
2006-07-27 7:37 Michael Wu
2006-07-31 20:31 ` John W. Linville
2006-07-31 20:51 ` Michael Wu
2006-08-01 9:56 ` Christoph Hellwig
2006-08-01 12:21 ` John W. Linville
2006-08-01 13:58 ` Jiri Benc
2006-08-01 14:07 ` John W. Linville
2006-08-01 14:25 ` Ivo Van Doorn
2006-08-01 17:11 ` John W. Linville
2006-08-01 17:31 ` Ivo van Doorn
2006-08-01 19:13 ` Ulrich Kunitz
2006-08-05 11:46 ` Christoph Hellwig
2006-08-05 17:30 ` Michael Buesch
2006-08-05 17:47 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607260944.01692.flamingice@sourmilk.net \
--to=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).