From: Stephen Hemminger <shemminger@osdl.org>
To: akpm@osdl.org
Cc: netdev@vger.kernel.org
Subject: [PATCH] via-rhine: NAPI poll enable
Date: Wed, 26 Jul 2006 11:51:02 -0700 [thread overview]
Message-ID: <20060726115102.68e6adf0@localhost.localdomain> (raw)
The poll_enable should be in init_registers before enabling interrupts,
not in tx_timeout. Thanks for spotting it Roger.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- sky2.orig/drivers/net/via-rhine.c 2006-07-25 13:43:19.000000000 -0700
+++ sky2/drivers/net/via-rhine.c 2006-07-25 13:43:10.000000000 -0700
@@ -1048,6 +1048,8 @@
rhine_set_rx_mode(dev);
+ netif_poll_enable(dev);
+
/* Enable interrupts by setting the interrupt mask. */
iowrite16(IntrRxDone | IntrRxErr | IntrRxEmpty| IntrRxOverflow |
IntrRxDropped | IntrRxNoBuf | IntrTxAborted |
@@ -1199,7 +1201,6 @@
dev->trans_start = jiffies;
rp->stats.tx_errors++;
netif_wake_queue(dev);
- netif_poll_enable(dev);
}
static int rhine_start_tx(struct sk_buff *skb, struct net_device *dev)
reply other threads:[~2006-07-26 18:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060726115102.68e6adf0@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=akpm@osdl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox