Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

[Jiri Benc <jbenc@suse.cz>]

On Mon, 24 Jul 2006 23:02:50 -0700, Michael Wu wrote:
> These two attached patches also roll in a switch to MAC_FMT and MAC_ARG, and 
> use IEEE80211_DATA_LEN when possible. Otherwise, it's the same as before 
> except split into two patches.

Nice, thanks a lot.

One more thing (hopefully the last one), could you try to keep lines
under 80 characters? I understand that with such long identifiers it is
not always possible (it dramatically reduces readability of the code if
you try to force the limit in every case) but there are some places
where it is feasible.

Also, when changing a line that is indented with spaces instead of tab
characters, it's nice to convert that spaces to tabs. That's not a
requirement, though; I will modify the patch if you won't do it.

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs