From: "John W. Linville" <linville@tuxdriver.com>
To: Jesse Huang <jesse@icplus.com.tw>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
akpm@osdl.org, jgarzik@pobox.com
Subject: Re: [PATCH] Create IP100A Driver
Date: Thu, 27 Jul 2006 08:54:27 -0400 [thread overview]
Message-ID: <20060727125421.GB22935@tuxdriver.com> (raw)
In-Reply-To: <1154030065.5967.15.camel@localhost.localdomain>
On Thu, Jul 27, 2006 at 03:54:25PM -0400, Jesse Huang wrote:
> From: Jesse Huang <jesse@icplus.com.tw>
>
> This is the first version of IP100A Linux Driver.
One general comment is that your patch is whitespace-damaged,
undoubtedly mangled by your mailer. I would suggest that you use
a text- or curses-based mailer (like mutt or even mail) for sending
patches, but I'm sure there are graphical mailers that can be trained
to not be "too smart".
> +static struct pci_device_id ipf_pci_tbl[] __devinitdata = {
> + {0x1186, 0x1002, 0x1186, 0x1002, 0, 0, 0},
> + {0x1186, 0x1002, 0x1186, 0x1003, 0, 0, 1},
> + {0x1186, 0x1002, 0x1186, 0x1012, 0, 0, 2},
> + {0x1186, 0x1002, 0x1186, 0x1040, 0, 0, 3},
> + {0x1186, 0x1002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 4},
> + {0x13F0, 0x0201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 5},
> + {0x13F0, 0x0200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 6},
> + {0,}
> +};
This PCI ID table is identical to the one in the sundance driver.
What advantage does this driver offer over sundance?
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-07-27 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 19:54 [PATCH] Create IP100A Driver Jesse Huang
2006-07-27 8:40 ` Andrey Panin
2006-07-27 11:53 ` Neil Horman
2006-07-27 12:54 ` John W. Linville [this message]
2006-07-27 13:06 ` Neil Horman
2006-07-28 2:28 ` Jesse Huang
2006-07-28 2:23 ` Jesse Huang
2006-07-28 10:14 ` Jeff Garzik
2006-08-03 2:03 ` Jesse Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060727125421.GB22935@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akpm@osdl.org \
--cc=jesse@icplus.com.tw \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).