netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: David Miller <davem@davemloft.net>
Cc: akpm@osdl.org, yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru,
	jmorris@namei.org, kaber@coreworks.de, pekkas@netcore.fi,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support
Date: Fri, 28 Jul 2006 09:19:55 +0100	[thread overview]
Message-ID: <200607280919.55482@strip-the-willow> (raw)
In-Reply-To: <20060727.223010.63131639.davem@davemloft.net>

Hi David,

thank you very much for taking time to revise the code 
and for the detailed comments.


|  The amount of code duplication is absolutely enormous and
|  totally unnecessary.
You are right. 
So far I thought it better to keep UDP and UDP-Lite separate but an
intelligent code integration does seem the better way.


<snip>
|  It's mostly clerical work, but it will mean that we will have one
|  copy of all this code and as a result we won't even need a config
|  option for UDP-Lite.

I will start with the v4-side and post a small RFC patch to see whether
I got the concepts right. (Due to vacation, this will not before mid/end 
of August.)



Best regards
Gerrit

  reply	other threads:[~2006-07-28  8:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-14 16:19 [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support Gerrit Renker
2006-07-15 13:33 ` Herbert Xu
2006-07-16  9:29   ` Gerrit Renker
2006-07-28  5:30 ` David Miller
2006-07-28  8:19   ` Gerrit Renker [this message]
2006-07-28  8:25     ` David Miller
2006-09-19  7:25   ` [PATCHv3 1/4][RFC] net/ipv4: consolidated UDP / UDP-Lite code Gerrit Renker
2006-10-09  9:51     ` [PATCH-update][RFC] net: " Gerrit Renker
2006-10-11  2:38       ` David Miller
2006-10-11  7:40         ` Gerrit Renker
2006-10-12  7:49       ` Gerrit Renker
2006-10-12  9:01         ` David Miller
2006-10-13 15:14           ` [PATCHv4 1/3] net/ipv4: UDP-Lite support (RFC 3828) Gerrit Renker
2006-10-13 15:14           ` [PATCHv4 2/3] net/ipv6: v6-side of UDP-Lite Gerrit Renker
2006-10-13 15:14           ` [PATCHv4 3/3] net: UDP-Lite misc files Gerrit Renker
2006-09-19  7:25   ` [PATCHv3 2/4][RFC] net/ipv4: self-contained UDP-Lite module Gerrit Renker
2006-09-19  7:25   ` [PATCHv3 3/4][RFC] net: basic xfrm/netfilter support for UDP-Lite Gerrit Renker
2006-09-19  7:37     ` Patrick McHardy
2006-09-19  7:25   ` [PATCHv3 4/4][RFC] net: misc. files to support UDP-Lite Gerrit Renker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607280919.55482@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@coreworks.de \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pekkas@netcore.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).