netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: paul.moore@hp.com
Cc: netdev@vger.kernel.org, selinux@tycho.nsa.gov,
	davem@davemloft.net, sds@epoch.ncsc.mil, jmorris@redhat.com,
	pratt@argus-systems.com
Subject: Re: [PATCH 2/7] NetLabel: core network changes
Date: Fri, 28 Jul 2006 13:24:26 +0200	[thread overview]
Message-ID: <20060728112426.GE14627@postel.suug.ch> (raw)
In-Reply-To: <20060717155822.315389000@hp.com>

* paul.moore@hp.com <paul.moore@hp.com> 2006-07-17 11:52
> + * NetLabel makes use of the Generic NETLINK mechanism as a transport layer to
> + * send messages between kernel and user space.  The general format of a
> + * NetLabel message is shown below:
> + *
> + *  +-----------------+-------------------+--------- --- -- -
> + *  | struct nlmsghdr | struct genlmsghdr | payload
> + *  +-----------------+-------------------+--------- --- -- -
> + *
> + * The 'nlmsghdr' and 'genlmsghdr' structs should be dealt with like normal.
> + * The payload is dependent on the subsystem specified in the
> + * 'nlmsghdr->nlmsg_type' and should be defined below, supporting functions
> + * should be defined in the corresponding net/netlabel/netlabel_<subsys>.h|c
> + * file.  All of the fields in the NetLabel payload should be aligned using
> + * the alignment functions provided.
> + *
> + */
> +
> +/*
> + * NetLabel NETLINK protocol
> + */
> +

Is there a reason for not using any of the existing netlink and
genetlink interfaces in any of your patches? It's all duplicated
code.

  parent reply	other threads:[~2006-07-28 11:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-17 15:52 [PATCH 0/7] Updated patchset w/James' comments paul.moore
2006-07-17 15:52 ` [PATCH 1/7] NetLabel: documentation paul.moore
2006-07-28  7:51   ` David Miller
2006-07-28 18:52     ` Paul Moore
2006-07-17 15:52 ` [PATCH 2/7] NetLabel: core network changes paul.moore
2006-07-28  7:55   ` David Miller
2006-07-28 18:45     ` Paul Moore
2006-07-28 19:55       ` David Miller
2006-07-28 11:24   ` Thomas Graf [this message]
2006-07-28 17:58     ` Paul Moore
2006-07-28 18:12       ` Thomas Graf
2006-07-28 18:39         ` Paul Moore
2006-07-28 18:58           ` Thomas Graf
2006-07-28 19:08             ` Paul Moore
2006-07-28 19:43               ` Evgeniy Polyakov
2006-07-28 19:58               ` David Miller
2006-07-28 20:09                 ` Paul Moore
2006-07-28 20:56                   ` David Miller
2006-07-28 20:59                     ` Paul Moore
2006-07-17 15:52 ` [PATCH 3/7] NetLabel: CIPSOv4 engine paul.moore
2006-07-28  7:56   ` David Miller
2006-07-17 15:52 ` [PATCH 4/7] NetLabel: core NetLabel subsystem paul.moore
2006-07-17 15:52 ` [PATCH 5/7] NetLabel: CIPSOv4 and Unlabeled packet integration paul.moore
2006-07-17 15:52 ` [PATCH 6/7] NetLabel: SELinux support paul.moore
2006-07-17 15:52 ` [PATCH 7/7] NetLabel: tie NetLabel into the Kconfig system paul.moore
2006-07-17 18:48 ` [PATCH 0/7] Updated patchset w/James' comments Valdis.Kletnieks
2006-07-17 19:00   ` Paul Moore
  -- strict thread matches above, loose matches on Subject: below --
2006-07-31 12:43 [PATCH 2/7] NetLabel: core network changes Venkat Yekkirala
2006-07-31 14:16 ` Paul Moore
2006-07-29 16:34 Venkat Yekkirala
2006-07-29 21:03 ` Paul Moore
2006-07-14 18:57 [PATCH 0/7] Latest NetLabel patch for 2.6.19 paul.moore
2006-07-14 18:57 ` [PATCH 2/7] NetLabel: core network changes paul.moore
2006-07-14 23:34   ` James Morris
2006-07-14 23:36     ` David Miller
2006-07-15 14:48     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060728112426.GE14627@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=jmorris@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.moore@hp.com \
    --cc=pratt@argus-systems.com \
    --cc=sds@epoch.ncsc.mil \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).