From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [stable] [PATCH] e1000: add forgotten PCI ID for supported device Date: Fri, 28 Jul 2006 23:19:05 -0400 Message-ID: <20060729031859.GA23779@tuxdriver.com> References: <44CA8A59.40002@intel.com> <20060728231837.GA2109@kroah.com> <20060729002440.GA3284@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Brandeburg, Jesse" , "Kok, Auke-jan H" , stable@kernel.org, NetDev , "Ronciak, John" , "Kok, Auke" Return-path: Received: from ra.tuxdriver.com ([70.61.120.52]:61969 "EHLO ra.tuxdriver.com") by vger.kernel.org with ESMTP id S1751317AbWG2DUN (ORCPT ); Fri, 28 Jul 2006 23:20:13 -0400 To: Greg KH Content-Disposition: inline In-Reply-To: <20060729002440.GA3284@kroah.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Jul 28, 2006 at 05:24:40PM -0700, Greg KH wrote: > On Fri, Jul 28, 2006 at 05:04:49PM -0700, Brandeburg, Jesse wrote: > > The kernel driver advertises through our probe table and in our readme > > that we support this device (code is in e1000_main.c) but we don't load on > > it correctly due to an error when we submitted the patches (e1000_hw.c/h). > > > > Patch is very simple and low risk, but it is your call. > > Sorry, but for now, no. Users should be able to use the sysfs bind and > new_id interface to add new device support for your driver, if it's > written properly :) In this case it isn't an addition to the PCI ID table, but an actual added check in the code. You could make the argument that it is a bug since the PCI ID table says the device is supported, but it won't work w/o this additional check. Of course, the "if it's written properly" comment is still valid... :-) John -- John W. Linville linville@tuxdriver.com