From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org,
Stephen Hemminger <shemminger@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Pekka Savola <pekkas@netcore.fi>,
Patrick McHardy <kaber@coreworks.de>,
netdev@vger.kernel.org
Subject: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
Date: Sun, 30 Jul 2006 21:38:02 +0200 [thread overview]
Message-ID: <200607302138.02855.jesper.juhl@gmail.com> (raw)
There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
We are not freeing 'tbuf' on error.
Patch below fixes that.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
net/ipv4/tcp_probe.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.18-rc3-orig/net/ipv4/tcp_probe.c 2006-07-30 13:21:53.000000000 +0200
+++ linux-2.6.18-rc3/net/ipv4/tcp_probe.c 2006-07-30 21:32:04.000000000 +0200
@@ -129,8 +129,10 @@ static ssize_t tcpprobe_read(struct file
error = wait_event_interruptible(tcpw.wait,
__kfifo_len(tcpw.fifo) != 0);
- if (error)
+ if (error) {
+ vfree(tbuf);
return error;
+ }
cnt = kfifo_get(tcpw.fifo, tbuf, len);
error = copy_to_user(buf, tbuf, cnt);
next reply other threads:[~2006-07-30 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-30 19:38 Jesper Juhl [this message]
2006-07-30 21:29 ` [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() Stephen Hemminger
2006-07-30 21:48 ` James Morris
2006-07-30 21:51 ` Jesper Juhl
2006-07-30 22:56 ` David Miller
2006-08-04 23:30 ` Jesper Juhl
2006-08-04 23:59 ` David Miller
2006-08-10 22:18 ` Jesper Juhl
2006-08-10 23:36 ` David Miller
2006-08-10 23:52 ` Stephen Hemminger
2006-08-10 23:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607302138.02855.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shemminger@osdl.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).