From: David Miller <davem@davemloft.net>
To: yjwei@nanjing-fnst.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix UDP filter condition when do checksum
Date: Mon, 31 Jul 2006 05:02:01 -0700 (PDT) [thread overview]
Message-ID: <20060731.050201.18308966.davem@davemloft.net> (raw)
In-Reply-To: <1154342022.3959.10.camel@LINE>
From: Wei Yongjun <yjwei@nanjing-fnst.com>
Date: Mon, 31 Jul 2006 06:33:42 -0400
> In udp_queue_rcv_skb(), checksum condition is error. When UDP filter is
> set, checksum is be done, but if UDP filter is not set, checksum will
> not be done. So I think this is a BUG.
It is not a bug, we defer the checksum, when we can, to sys_recvmsg()
where we can combine the copy into userspace and the checksum
calculation into one operation.
We cannot do this deferral when there is a filter attached, and that
is why the check is the way it is.
prev parent reply other threads:[~2006-07-31 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-31 10:33 [PATCH] Fix UDP filter condition when do checksum Wei Yongjun
2006-07-31 11:36 ` Herbert Xu
2006-07-31 12:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731.050201.18308966.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yjwei@nanjing-fnst.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).