From: "John W. Linville" <linville@tuxdriver.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>, netdev@vger.kernel.org
Subject: Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names
Date: Mon, 31 Jul 2006 16:31:19 -0400 [thread overview]
Message-ID: <20060731203113.GG10138@tuxdriver.com> (raw)
In-Reply-To: <200607270037.22384.flamingice@sourmilk.net>
On Thu, Jul 27, 2006 at 12:37:14AM -0700, Michael Wu wrote:
> Alright, I've replaced all + lines with spaces with tabs.
>
> I also fixed one long line. The rest of them are nearly impossible to shorten
> well. The "(fc & IEEE80211_FCTL_FTYPE) == IEEE80211_FTYPE_DATA" style is
> really killing us (unless you want to break after ==, which is rather bad). I
> think we should switch back to a macro for that.
>
> I would prefer if we could get this merged soon and put in that line
> shortening macro later (or whatever solution that's best), but it's your
> call.
Michael,
As usual I'll depend on Jiri to merge d80211 stack patches, then
send me a pull request. If I apply your "Switch drivers to d80211"
series now, that will undoutedly cause a breakage when Jiri asks me
to pull this later.
I presume that at least parts of those patches will still be necessary
or desirable after the d80211 symbol rename gets merged. Are you
preparing a new patch series for when that happens?
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-07-31 20:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 7:37 [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names Michael Wu
2006-07-31 20:31 ` John W. Linville [this message]
2006-07-31 20:51 ` Michael Wu
2006-08-01 9:56 ` Christoph Hellwig
2006-08-01 12:21 ` John W. Linville
2006-08-01 13:58 ` Jiri Benc
2006-08-01 14:07 ` John W. Linville
2006-08-01 14:25 ` Ivo Van Doorn
2006-08-01 17:11 ` John W. Linville
2006-08-01 17:31 ` Ivo van Doorn
2006-08-01 19:13 ` Ulrich Kunitz
2006-08-05 11:46 ` Christoph Hellwig
2006-08-05 17:30 ` Michael Buesch
2006-08-05 17:47 ` Michael Buesch
-- strict thread matches above, loose matches on Subject: below --
2006-07-25 6:02 Michael Wu
2006-07-26 16:32 ` Jiri Benc
2006-07-26 16:43 ` Michael Wu
2006-07-26 16:53 ` Jiri Benc
2006-07-26 17:10 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060731203113.GG10138@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).