From: David Miller <davem@davemloft.net>
To: brian.haley@hp.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] IPv6: only set err in rawv6_bind() when necessary
Date: Tue, 01 Aug 2006 15:03:52 -0700 (PDT) [thread overview]
Message-ID: <20060801.150352.104034113.davem@davemloft.net> (raw)
In-Reply-To: <44CF89FB.2060208@hp.com>
From: Brian Haley <brian.haley@hp.com>
Date: Tue, 01 Aug 2006 13:06:03 -0400
> The variable 'err' is set in rawv6_bind() before the address check fails
> instead of after, moved inside if() statement.
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
This is a common C idiom in the kernel:
err = -EWHATEVER;
if (error_condition)
goto out;
err = 0;
out:
unlock_stuff();
return err;
Every other path going from this location in rawv6_bind()
will clear err to zero, so your patch also doesn't fix any
bug.
next prev parent reply other threads:[~2006-08-01 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 17:06 [PATCH] IPv6: only set err in rawv6_bind() when necessary Brian Haley
2006-08-01 22:03 ` David Miller [this message]
2006-08-02 16:04 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801.150352.104034113.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brian.haley@hp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).