netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nakam@linux-ipv6.org
Cc: yoshfuji@linux-ipv6.org, anttit@tcs.hut.fi, vnuorval@tcs.hut.fi,
	netdev@vger.kernel.org, usagi-core@linux-ipv6.org
Subject: Re: [PATCH 5/23] [PATCH] [XFRM] STATE: Add source address list.
Date: Tue, 01 Aug 2006 16:57:28 -0700 (PDT)	[thread overview]
Message-ID: <20060801.165728.18308673.davem@davemloft.net> (raw)
In-Reply-To: <11541654121350-git-send-email-nakam@linux-ipv6.org>

From: Masahide NAKAMURA <nakam@linux-ipv6.org>
Date: Sat, 29 Jul 2006 18:30:12 +0900

> @@ -263,6 +263,7 @@ struct xfrm_usersa_id {
>  	__u32				spi;
>  	__u16				family;
>  	__u8				proto;
> +	xfrm_address_t			saddr;
>  };
>  
>  struct xfrm_aevent_id {

This is a userspace exported structure, therefore you cannot
make changes to it like this, it will break the userland API.

If you need to provide the source address, you need to pass it in via
a new xfrm netlink attribute or use an existing data structure member
which records the source address (if any such thing does exist).

  reply	other threads:[~2006-08-01 23:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29  9:30 [PATCH 5/23] [PATCH] [XFRM] STATE: Add source address list Masahide NAKAMURA
2006-08-01 23:57 ` David Miller [this message]
2006-08-02  1:42   ` Masahide NAKAMURA
2006-08-02  2:03     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060801.165728.18308673.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anttit@tcs.hut.fi \
    --cc=nakam@linux-ipv6.org \
    --cc=netdev@vger.kernel.org \
    --cc=usagi-core@linux-ipv6.org \
    --cc=vnuorval@tcs.hut.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).