From: David Miller <davem@davemloft.net>
To: nakam@linux-ipv6.org
Cc: yoshfuji@linux-ipv6.org, anttit@tcs.hut.fi, vnuorval@tcs.hut.fi,
netdev@vger.kernel.org, usagi-core@linux-ipv6.org
Subject: Re: [PATCH 6/23] [PATCH] [XFRM] STATE: Search by address using source address list.
Date: Tue, 01 Aug 2006 17:06:18 -0700 (PDT) [thread overview]
Message-ID: <20060801.170618.75430766.davem@davemloft.net> (raw)
In-Reply-To: <11541654182334-git-send-email-nakam@linux-ipv6.org>
From: Masahide NAKAMURA <nakam@linux-ipv6.org>
Date: Sat, 29 Jul 2006 18:30:18 +0900
> +#ifdef CONFIG_XFRM_ADVANCED
> + struct xfrm_state *(*state_lookup_byaddr)(xfrm_address_t *daddr, xfrm_address_t *saddr, u8 proto);
> +#endif
I think we should delete XFRM_ADVANCED config option, it is only
serving to make the code very ugly and full of ifdefs.
> +#ifdef CONFIG_XFRM_ADVANCED
> + int use_spi = xfrm_id_proto_match(x->id.proto, IPSEC_PROTO_ANY);
> +#else
> + int use_spi = 1;
> +#endif
Why this transformation? In fact, you added several others.
xfrm_id_proto_match() with userproto argument IPSEC_PROTO_ANY
always evaluates to one.
If you intend to change the userproto argument in some future
changeset, then add the xfrm_id_proto_match() call in that
changeset.
next prev parent reply other threads:[~2006-08-02 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 9:30 [PATCH 6/23] [PATCH] [XFRM] STATE: Search by address using source address list Masahide NAKAMURA
2006-08-02 0:06 ` David Miller [this message]
2006-08-02 2:04 ` Masahide NAKAMURA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060801.170618.75430766.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anttit@tcs.hut.fi \
--cc=nakam@linux-ipv6.org \
--cc=netdev@vger.kernel.org \
--cc=usagi-core@linux-ipv6.org \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).