[git patches] tulip fixes from parisc-linux

[git patches] tulip fixes from parisc-linux

[Kyle McMartin]

Hi Val,

Sorry it took so long for me to get around to splitting
up the changes from the parisc-linux tree. But here
they finally are. This patchset has been running on a
variety of parisc and ia64 machines for quite some
time (several years...) without issue. Some of these
are more cosmetic changes than anything else.

Cheers,
	Kyle M.

The following changes since commit dc710afe95ee9b263ab593c11d86a684f1606872:
  Linus Torvalds:
        Merge branch 'upstream-linus' of master.kernel.org:/.../jgarzik/libata-dev

are found in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kyle/tulip-2.6.git

Francois Romieu:
      [TULIP] Defer tulip_select_media() to process context

Grant Grundler:
      [TULIP] Fix PHY init and reset
      [TULIP] Print physical address in tulip_init_one
      [TULIP] Make tulip_stop_rxtx() failure case slightly more informative
      [TULIP] Clean tulip.h so it can be used by winbond-840.c
      [TULIP] Flush MMIO writes in reset sequence
      [TULIP] Fix IRQ/DMA race

Helge Deller:
      [TULIP] Fix section mismatch in de2104x.c

Thibaut Varene:
      [TULIP] Make DS21143 printout match lspci output

 drivers/net/tulip/21142.c       |    4 +-
 drivers/net/tulip/de2104x.c     |    6 +-
 drivers/net/tulip/interrupt.c   |    4 ++
 drivers/net/tulip/media.c       |   40 ++++++++++++++-
 drivers/net/tulip/timer.c       |   14 +++++
 drivers/net/tulip/tulip.h       |   43 ++++++++++++----
 drivers/net/tulip/tulip_core.c  |  102 +++++++++++++++++++--------------------
 drivers/net/tulip/winbond-840.c |   68 +++++++++-----------------
 8 files changed, 164 insertions(+), 117 deletions(-)

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Grant Grundler]

On Sat, Jul 29, 2006 at 06:54:59PM -0400, Kyle McMartin wrote:
> Hi Val,
> 
> Sorry it took so long for me to get around to splitting
> up the changes from the parisc-linux tree. But here
> they finally are.

Kyle,
dude, you rock!
Many thanks for doing that.

I just wanted to warn that some of the changes are already in akpm
's tree (-mm).
Becuase off hand I've forgotten which ones, would it be better to
diff against -mm instead?

thanks,
grant

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Kyle McMartin]

On Sat, Jul 29, 2006 at 06:43:39PM -0600, Grant Grundler wrote:
> I just wanted to warn that some of the changes are already in akpm
> 's tree (-mm).
> Becuase off hand I've forgotten which ones, would it be better to
> diff against -mm instead?

tulip-fix-shutdown-dma-irq-race.patch
  tulip: fix shutdown DMA/irq race

tulip-fix-for-64-bit-mips.patch
  tulip: fix for 64-bit mips

tulip-natsemi-dp83840a-phy-fix.patch
  tulip: NatSemi DP83840A PHY fix

Are the tulip patches in -mm, found here:
http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-fix-for-64-bit-mips.patch
http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-fix-shutdown-dma-irq-race.patch
http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-natsemi-dp83840a-phy-fix.patch

[akpm: I added you to the CC list, if Val acks the patches can
you see that they make their way into -mm?
git.kernel.org/pub/scm/linux/kernel/git/kyle/tulip-2.6.git#master]

Cheers,
	Kyle M.

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Andrew Morton]

On Sun, 30 Jul 2006 12:56:07 -0400
Kyle McMartin <kyle@parisc-linux.org> wrote:

> On Sat, Jul 29, 2006 at 06:43:39PM -0600, Grant Grundler wrote:
> > I just wanted to warn that some of the changes are already in akpm
> > 's tree (-mm).
> > Becuase off hand I've forgotten which ones, would it be better to
> > diff against -mm instead?
> 
> tulip-fix-shutdown-dma-irq-race.patch
>   tulip: fix shutdown DMA/irq race
> 
> tulip-fix-for-64-bit-mips.patch
>   tulip: fix for 64-bit mips
> 
> tulip-natsemi-dp83840a-phy-fix.patch
>   tulip: NatSemi DP83840A PHY fix
> 
> Are the tulip patches in -mm, found here:
> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-fix-for-64-bit-mips.patch
> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-fix-shutdown-dma-irq-race.patch
> http://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/broken-out/tulip-natsemi-dp83840a-phy-fix.patch
> 
> [akpm: I added you to the CC list, if Val acks the patches can
> you see that they make their way into -mm?
> git.kernel.org/pub/scm/linux/kernel/git/kyle/tulip-2.6.git#master]
> 

hm.  A couple of those patches have been futzing around in -mm for over a
year and have been nacked by Jeff and are a regular source of grumpygrams. 
I've been sitting on them in the pathetic hope that someone will one day
get down and address the bugs which they fix in an acceptable fashion,
whatever that is.

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Kyle McMartin]

On Sun, Jul 30, 2006 at 11:35:32AM -0700, Andrew Morton wrote:
> hm.  A couple of those patches have been futzing around in -mm for over a
> year and have been nacked by Jeff and are a regular source of grumpygrams. 
> I've been sitting on them in the pathetic hope that someone will one day
> get down and address the bugs which they fix in an acceptable fashion,
> whatever that is.
> 

Jeff/Val seemed willing to merge the fixes as they stood. parisc-linux
merged Francois' tulip workqueue patch some time ago, and have been
running with it since without issue. This defers the tulip_select_media
work to process context, and so should be less of an issue.

Cheers,
	Kyle

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Jeff Garzik]

Kyle McMartin wrote:
> parisc-linux
> merged Francois' tulip workqueue patch some time ago, and have been
> running with it since without issue. This defers the tulip_select_media
> work to process context, and so should be less of an issue.

Good to hear.  That's definitely my preference for future direction...

	Jeff

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Valerie Henson]

On Sun, Jul 30, 2006 at 02:54:56PM -0400, Kyle McMartin wrote:
> On Sun, Jul 30, 2006 at 11:35:32AM -0700, Andrew Morton wrote:
> > hm.  A couple of those patches have been futzing around in -mm for over a
> > year and have been nacked by Jeff and are a regular source of grumpygrams. 
> > I've been sitting on them in the pathetic hope that someone will one day
> > get down and address the bugs which they fix in an acceptable fashion,
> > whatever that is.
> > 
> 
> Jeff/Val seemed willing to merge the fixes as they stood. parisc-linux
> merged Francois' tulip workqueue patch some time ago, and have been
> running with it since without issue. This defers the tulip_select_media
> work to process context, and so should be less of an issue.

Hey Kyle,

Thanks for splitting these out.  Could you do us a favor and post the
patches themselves?  I'm not the only one who doesn't use git, and it
will be a lot less confusing if we can directly ack the patches in
email instead of referring to them third-hand.  Thanks,

-VAL

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

[Jeff Garzik]

Andrew Morton wrote:
> hm.  A couple of those patches have been futzing around in -mm for over a
> year and have been nacked by Jeff and are a regular source of grumpygrams. 
> I've been sitting on them in the pathetic hope that someone will one day
> get down and address the bugs which they fix in an acceptable fashion,
> whatever that is.


I'm OK with the one sent -> Grant -> Val -> me.

	Jeff