* [PATCH] DECnet Fix for DECnet routing bug
@ 2006-08-02 14:19 Patrick Caulfield
2006-08-02 21:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Caulfield @ 2006-08-02 14:19 UTC (permalink / raw)
To: davem, netdev; +Cc: steve
This patch fixes a bug in the DECnet routing code where we were selecting
a loopback device in preference to an outward facing device even when
the destination was known non-local. This patch should fix the problem.
Signed-off-by: Patrick Caulfield <patrick@tykepenguin.com>
Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 1355614..743e9fc 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -925,8 +925,13 @@ static int dn_route_output_slow(struct d
for(dev_out = dev_base; dev_out; dev_out = dev_out->next) {
if (!dev_out->dn_ptr)
continue;
- if (dn_dev_islocal(dev_out, oldflp->fld_src))
- break;
+ if (!dn_dev_islocal(dev_out, oldflp->fld_src))
+ continue;
+ if ((dev_out->flags & IFF_LOOPBACK) &&
+ oldflp->fld_dst &&
+ !dn_dev_islocal(dev_out, oldflp->fld_dst))
+ continue;
+ break;
}
read_unlock(&dev_base_lock);
if (dev_out == NULL)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] DECnet Fix for DECnet routing bug
2006-08-02 14:19 [PATCH] DECnet Fix for DECnet routing bug Patrick Caulfield
@ 2006-08-02 21:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-08-02 21:14 UTC (permalink / raw)
To: patrick; +Cc: netdev, steve
From: Patrick Caulfield <patrick@tykepenguin.com>
Date: Wed, 02 Aug 2006 15:19:24 +0100
> This patch fixes a bug in the DECnet routing code where we were selecting
> a loopback device in preference to an outward facing device even when
> the destination was known non-local. This patch should fix the problem.
>
> Signed-off-by: Patrick Caulfield <patrick@tykepenguin.com>
> Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
Applied, thanks Patrick.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-02 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-02 14:19 [PATCH] DECnet Fix for DECnet routing bug Patrick Caulfield
2006-08-02 21:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).