netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] llc: multicast receive device match
Date: Thu, 3 Aug 2006 10:05:58 -0700	[thread overview]
Message-ID: <20060803100558.72ff1863@localhost.localdomain> (raw)

Fix from Aji_Srinivas@emc.com, STP packets are incorrectly received on all
LLC datagram sockets, whichever interface they are bound to. 
The llc_sap datagram receive logic sends packets with a unicast destination 
MAC to one socket bound to that SAP and MAC, and multicast packets to all sockets
bound to that SAP. STP packets are multicast, and we do need to know
on which interface they were received.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
---
 net/llc/llc_sap.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/llc/llc_sap.c b/net/llc/llc_sap.c
index 42eb0c3..61cb8cf 100644
--- a/net/llc/llc_sap.c
+++ b/net/llc/llc_sap.c
@@ -330,6 +330,9 @@ static void llc_sap_mcast(struct llc_sap
 		if (llc->laddr.lsap != laddr->lsap)
 			continue;
 
+		if (llc->dev != skb->dev)
+			continue;
+
 		skb1 = skb_clone(skb, GFP_ATOMIC);
 		if (!skb1)
 			break;
-- 
1.4.0


-- 

             reply	other threads:[~2006-08-03 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-03 17:05 Stephen Hemminger [this message]
2006-08-11  0:35 ` [PATCH] llc: multicast receive device match David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060803100558.72ff1863@localhost.localdomain \
    --to=shemminger@osdl.org \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).