* [PATCH] llc: multicast receive device match
@ 2006-08-03 17:05 Stephen Hemminger
2006-08-11 0:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2006-08-03 17:05 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, David S. Miller; +Cc: netdev
Fix from Aji_Srinivas@emc.com, STP packets are incorrectly received on all
LLC datagram sockets, whichever interface they are bound to.
The llc_sap datagram receive logic sends packets with a unicast destination
MAC to one socket bound to that SAP and MAC, and multicast packets to all sockets
bound to that SAP. STP packets are multicast, and we do need to know
on which interface they were received.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
---
net/llc/llc_sap.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/llc/llc_sap.c b/net/llc/llc_sap.c
index 42eb0c3..61cb8cf 100644
--- a/net/llc/llc_sap.c
+++ b/net/llc/llc_sap.c
@@ -330,6 +330,9 @@ static void llc_sap_mcast(struct llc_sap
if (llc->laddr.lsap != laddr->lsap)
continue;
+ if (llc->dev != skb->dev)
+ continue;
+
skb1 = skb_clone(skb, GFP_ATOMIC);
if (!skb1)
break;
--
1.4.0
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] llc: multicast receive device match
2006-08-03 17:05 [PATCH] llc: multicast receive device match Stephen Hemminger
@ 2006-08-11 0:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-08-11 0:35 UTC (permalink / raw)
To: shemminger; +Cc: acme, netdev
From: Stephen Hemminger <shemminger@osdl.org>
Date: Thu, 3 Aug 2006 10:05:58 -0700
> Fix from Aji_Srinivas@emc.com, STP packets are incorrectly received on all
> LLC datagram sockets, whichever interface they are bound to.
> The llc_sap datagram receive logic sends packets with a unicast destination
> MAC to one socket bound to that SAP and MAC, and multicast packets to all sockets
> bound to that SAP. STP packets are multicast, and we do need to know
> on which interface they were received.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Looks correct, I will apply this.
Thanks a lot.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-11 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-03 17:05 [PATCH] llc: multicast receive device match Stephen Hemminger
2006-08-11 0:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).