netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@hpl.hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Arjan van de Ven <arjan@infradead.org>,
	davej@redhat.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, davem@davemloft.net,
	linville@tuxdriver.com, jt@hpl.hp.com
Subject: Re: orinoco driver causes *lots* of lockdep spew
Date: Thu, 3 Aug 2006 11:55:44 -0700	[thread overview]
Message-ID: <20060803185544.GA12062@bougret.hpl.hp.com> (raw)
In-Reply-To: <E1G8der-0001fm-00@gondolin.me.apana.org.au>

On Thu, Aug 03, 2006 at 11:54:41PM +1000, Herbert Xu wrote:
> Arjan van de Ven <arjan@infradead.org> wrote:
> > 
> > this is another one of those nasty buggers;
> 
> Good catch.  It's really time that we fix this properly rather than
> adding more kludges to the core code.
> 
> Dave, once this goes in you can revert the previous netlink workaround
> that added the _bh suffix.
> 
> [WIRELESS]: Send wireless netlink events with a clean slate
> 
> Drivers expect to be able to call wireless_send_event in arbitrary
> contexts.  On the other hand, netlink really doesn't like being
> invoked in an IRQ context.  So we need to postpone the sending of
> netlink skb's to a tasklet.

	Yes, this was needed. I really like the way you implemented
it, simple and efficient. Go for it !

> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 

	For what it's worth :
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>

> Cheers,

	Thanks !

	Jean

  parent reply	other threads:[~2006-08-03 18:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-02 21:59 orinoco driver causes *lots* of lockdep spew Dave Jones
2006-08-03 12:15 ` Arjan van de Ven
2006-08-03 13:54   ` Herbert Xu
2006-08-03 14:11     ` Christoph Hellwig
2006-08-03 18:58       ` Jean Tourrilhes
2006-08-03 18:59         ` Dave Jones
2006-08-03 19:40           ` Jean Tourrilhes
2006-08-03 19:45             ` Arjan van de Ven
2006-08-03 18:59       ` Dave Jones
2006-08-03 15:22     ` Arjan van de Ven
2006-08-04  1:05       ` Herbert Xu
2006-08-03 18:55     ` Jean Tourrilhes [this message]
2006-08-03 19:53     ` John W. Linville
2006-08-04  1:06       ` Herbert Xu
2006-08-04  2:11       ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060803185544.GA12062@bougret.hpl.hp.com \
    --to=jt@hpl.hp.com \
    --cc=arjan@infradead.org \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).