From: David Miller <davem@davemloft.net>
To: jesper.juhl@gmail.com
Cc: jmorris@namei.org, shemminger@osdl.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, pekkas@netcore.fi, kaber@coreworks.de,
netdev@vger.kernel.org
Subject: Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
Date: Fri, 04 Aug 2006 16:59:31 -0700 (PDT) [thread overview]
Message-ID: <20060804.165931.48505912.davem@davemloft.net> (raw)
In-Reply-To: <9a8748490608041630t5e667bf5k3a50dcf148187e6c@mail.gmail.com>
From: "Jesper Juhl" <jesper.juhl@gmail.com>
Date: Sat, 5 Aug 2006 01:30:49 +0200
> On 31/07/06, David Miller <davem@davemloft.net> wrote:
> > From: "Jesper Juhl" <jesper.juhl@gmail.com>
> > Date: Sun, 30 Jul 2006 23:51:20 +0200
> >
> > > Looks ok to me.
> >
> > I've applied James's version of the fix, thanks everyone.
> >
> Hmm, if you are refering to commit
> 118075b3cdc90e0815362365f3fc64d672ace0d6 -
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=118075b3cdc90e0815362365f3fc64d672ace0d6
> then I think a mistake has crept in. That commit only initializes
> 'cnt' to 0 - I don't see how that would fix the leak - looks like you
> forgot the business end of the patch...
See the commit right before that, the initialize of cnt to
zero is just to fix a compiler warning that resulted from
James's version of the fix.
next prev parent reply other threads:[~2006-08-04 23:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-30 19:38 [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() Jesper Juhl
2006-07-30 21:29 ` Stephen Hemminger
2006-07-30 21:48 ` James Morris
2006-07-30 21:51 ` Jesper Juhl
2006-07-30 22:56 ` David Miller
2006-08-04 23:30 ` Jesper Juhl
2006-08-04 23:59 ` David Miller [this message]
2006-08-10 22:18 ` Jesper Juhl
2006-08-10 23:36 ` David Miller
2006-08-10 23:52 ` Stephen Hemminger
2006-08-10 23:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060804.165931.48505912.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jesper.juhl@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@coreworks.de \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shemminger@osdl.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).