From: David Miller <davem@davemloft.net>
To: shemminger@osdl.org
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH 9/9] [NET]: Move netlink interface bits to linux/if.h
Date: Fri, 04 Aug 2006 23:23:14 -0700 (PDT) [thread overview]
Message-ID: <20060804.232314.105406244.davem@davemloft.net> (raw)
In-Reply-To: <44D5813A.1070309@osdl.org>
From: Stephen Hemminger <shemminger@osdl.org>
Date: Sat, 05 Aug 2006 22:42:18 -0700
> Thomas Graf wrote:
> > -/* The struct should be in sync with struct net_device_stats */
> > -struct rtnl_link_stats
> > -{
> > - __u32 rx_packets; /* total packets received */
> > - __u32 tx_packets; /* total packets transmitted */
> > - __u32 rx_bytes; /* total bytes received */
> > - __u32 tx_bytes; /* total bytes transmitted */
> >
>
> Make the packets and byte counts __u64 so if/when we extend net_device
> stats to bigger
> values, the message format doesn't have to change.
It's an existing ABI that he is just moving from one place
to another, we are not at liberty to change it's layout.
We chould create a new one, but that makes no sense until
the device layer actually has the means by which to maintain
u64 values.
next prev parent reply other threads:[~2006-08-05 6:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-05 0:34 [PATCHSET] Begin of transformations to new netlink api Thomas Graf
2006-08-04 22:00 ` [PATCH 1/9] [NETLINK]: Extend netlink messaging interface Thomas Graf
2006-08-04 22:00 ` [PATCH 2/9] [NETLINK]: Convert core netlink handling to new netlink api Thomas Graf
2006-08-04 22:00 ` [PATCH 3/9] [IPV4]: Convert address addition " Thomas Graf
2006-08-04 22:00 ` [PATCH 4/9] [IPV4]: Convert address deletion " Thomas Graf
2006-08-04 22:00 ` [PATCH 5/9] [IPV4]: Convert address dumping " Thomas Graf
2006-08-04 22:00 ` [PATCH 6/9] [IPv4]: Move interface address bits to linux/if_addr.h Thomas Graf
2006-08-04 22:00 ` [PATCH 7/9] [NET]: Convert link modification to new netlink api Thomas Graf
2006-08-04 22:00 ` [PATCH 8/9] [NET]: Convert link dumping " Thomas Graf
2006-08-04 22:00 ` [PATCH 9/9] [NET]: Move netlink interface bits to linux/if.h Thomas Graf
2006-08-06 5:42 ` Stephen Hemminger
2006-08-05 6:23 ` David Miller [this message]
2006-08-07 17:57 ` Stephen Hemminger
2006-08-05 6:21 ` [PATCHSET] Begin of transformations to new netlink api David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060804.232314.105406244.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).