netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: tgraf@suug.ch, netdev@vger.kernel.org, vnuorval@tcs.hut.fi,
	usagi-core@linux-ipv6.org, yoshfuji@linux-ipv6.org,
	anttit@tcs.hut.fi
Subject: Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables
Date: Sat, 05 Aug 2006 02:21:11 -0700 (PDT)	[thread overview]
Message-ID: <20060805.022111.17843589.davem@davemloft.net> (raw)
In-Reply-To: <44D45E34.9030607@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Sat, 05 Aug 2006 11:00:36 +0200

> Thomas Graf wrote:
> > +	if (rt->rt6i_table)
> > +		rtm->rtm_table = rt->rt6i_table->tb6_id;
> > +	else
> > +		rtm->rtm_table = RT6_TABLE_UNSPEC;
> >  	rtm->rtm_table = RT_TABLE_MAIN;
> 
> 
> This looks like a mistake, the table ID is overwritten again.
> 
> Signed-off-by: Patrick McHardy <kaber@trash.net>

Good catch Patrick, patch applied.

Thanks a lot.

  reply	other threads:[~2006-08-05  9:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-04 10:23 [PATCHSET] Multiple IPV6 Routing Tables & Policy Routing Thomas Graf
2006-08-03 22:00 ` [PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency Thomas Graf
2006-08-03 22:00 ` [PATCH 2/5] [IPV6]: Multiple Routing Tables Thomas Graf
2006-08-05  9:00   ` Patrick McHardy
2006-08-05  9:21     ` David Miller [this message]
2006-08-03 22:00 ` [PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework Thomas Graf
2006-08-03 22:00 ` [PATCH 4/5] [IPV6]: Policy Routing Rules Thomas Graf
2006-08-03 22:00 ` [PATCH 5/5] [IPV4]: Use Protocol Independant Policy Routing Rules Framework Thomas Graf
2006-08-04 10:40 ` [PATCHSET] Multiple IPV6 Routing Tables & Policy Routing David Miller
2006-08-04 15:58 ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-04 17:41   ` Thomas Graf
2006-08-04 18:14     ` YOSHIFUJI Hideaki / 吉藤英明
  -- strict thread matches above, loose matches on Subject: below --
2006-07-26 22:11 [RFC] " Thomas Graf
2006-07-26 22:00 ` [PATCH 2/5] [IPV6]: Multiple Routing Tables Thomas Graf
2006-07-26 22:39   ` David Miller
2006-07-26 22:48     ` Thomas Graf
2006-07-26 22:55       ` David Miller
2006-07-29  4:13   ` YOSHIFUJI Hideaki / 吉藤英明
2006-07-29  4:14     ` David Miller
2006-07-29  4:28       ` YOSHIFUJI Hideaki / 吉藤英明
2006-07-29 10:29     ` Thomas Graf
2006-07-31 13:55   ` Ville Nuorvala
2006-07-31 14:01     ` Herbert Xu
2006-07-31 14:02       ` Herbert Xu
2006-07-31 15:41       ` Thomas Graf
2006-07-31 20:09         ` David Miller
2006-07-31 15:34     ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060805.022111.17843589.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=anttit@tcs.hut.fi \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    --cc=usagi-core@linux-ipv6.org \
    --cc=vnuorval@tcs.hut.fi \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).