From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: acme@ghostprotocols.net, netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ipx: header length validation needed
Date: Mon, 7 Aug 2006 16:36:02 -0700 [thread overview]
Message-ID: <20060807163602.5c7a4a65@localhost.localdomain> (raw)
In-Reply-To: <20060807.162433.26101101.davem@davemloft.net>
This patch will linearize and check there is enough data.
It handles the pprop case as well as avoiding a whole audit of
the routing code.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- a/net/ipx/af_ipx.c 2006-08-07 13:45:59.000000000 -0700
+++ b/net/ipx/af_ipx.c 2006-08-07 16:34:00.000000000 -0700
@@ -1649,7 +1649,8 @@
ipx_pktsize = ntohs(ipx->ipx_pktsize);
/* Too small or invalid header? */
- if (ipx_pktsize < sizeof(struct ipxhdr) || ipx_pktsize > skb->len)
+ if (ipx_pktsize < sizeof(struct ipxhdr)
+ || !pskb_may_pull(skb, ipx_pktsize))
goto drop;
if (ipx->ipx_checksum != IPX_NO_CHECKSUM &&
next prev parent reply other threads:[~2006-08-07 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 20:46 [PATCH] ipx: header length validation needed Stephen Hemminger
2006-08-07 23:24 ` David Miller
2006-08-07 23:36 ` Stephen Hemminger [this message]
2006-08-08 3:10 ` David Miller
2006-08-10 6:50 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807163602.5c7a4a65@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).