From: Jouni Malinen <jkm@devicescape.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Jiri Benc <jbenc@suse.cz>,
netdev@vger.kernel.org, jkm@devicescape.com, jkmaline@cc.hut.fi
Subject: [PATCH wireless-dev 5/6] d80211: Fix ieee80211_remove_tx_extra() if key not configured
Date: Mon, 07 Aug 2006 16:16:13 -0700 [thread overview]
Message-ID: <20060807231938.892291916@localhost> (raw)
In-Reply-To: 20060807231608.888744720@localhost
[-- Attachment #1: remove_tx_extra.patch --]
[-- Type: text/plain, Size: 1218 bytes --]
QoS header processing mangled unencrypted WMM frames on software
retry. The QoS data needs to be removed even when encryption key is
not configured.
Signed-off-by: Jouni Malinen <jkm@devicescape.com>
Index: wireless-dev/net/d80211/ieee80211.c
===================================================================
--- wireless-dev.orig/net/d80211/ieee80211.c
+++ wireless-dev/net/d80211/ieee80211.c
@@ -3977,11 +3977,11 @@ static void ieee80211_remove_tx_extra(st
pkt_data->requeue = control->requeue;
pkt_data->queue = control->queue;
- if (key == NULL)
- return;
-
hdrlen = ieee80211_get_hdrlen_from_skb(skb);
+ if (key == NULL)
+ goto no_key;
+
switch (key->alg) {
case ALG_WEP:
iv_len = WEP_IV_LEN;
@@ -3996,7 +3996,7 @@ static void ieee80211_remove_tx_extra(st
mic_len = CCMP_MIC_LEN;
break;
default:
- return;
+ goto no_key;
}
if (skb->len >= mic_len && key->force_sw_encrypt)
@@ -4006,6 +4006,7 @@ static void ieee80211_remove_tx_extra(st
skb_pull(skb, iv_len);
}
+no_key:
{
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
u16 fc = le16_to_cpu(hdr->frame_control);
--
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2006-08-07 23:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 23:16 [PATCH wireless-dev 0/6] Set of small fixes to net/d80211 Jouni Malinen
2006-08-07 23:16 ` [PATCH wireless-dev 1/6] d80211: Fix RTS threshold use Jouni Malinen
2006-08-07 23:16 ` [PATCH wireless-dev 2/6] d80211: Fix PS-Poll frame dropping Jouni Malinen
2006-08-07 23:16 ` [PATCH wireless-dev 3/6] d80211: Fix PLCP header length comment Jouni Malinen
2006-08-07 23:16 ` [PATCH wireless-dev 4/6] d80211: Send Layer 2 Update frames in kernel Jouni Malinen
2006-08-17 13:20 ` Jiri Benc
2006-08-23 17:22 ` Jiri Benc
2006-08-23 21:50 ` Stefan Rompf
2006-08-24 11:36 ` Jiri Benc
2006-08-24 5:39 ` Jouni Malinen
2006-08-24 11:43 ` Jiri Benc
2006-08-24 15:54 ` Jouni Malinen
2006-08-07 23:16 ` Jouni Malinen [this message]
2006-08-07 23:16 ` [PATCH wireless-dev 6/6] d80211: Fix TKIP replay protection Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807231938.892291916@localhost \
--to=jkm@devicescape.com \
--cc=jbenc@suse.cz \
--cc=jkmaline@cc.hut.fi \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).