From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC][PATCH 2/9] deadlock prevention core Date: Tue, 08 Aug 2006 18:41:44 -0700 (PDT) Message-ID: <20060808.184144.71088399.davem@davemloft.net> References: <20060808193345.1396.16773.sendpatchset@lappy> <20060808.151020.94555184.davem@davemloft.net> <44D93BEE.4000001@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: a.p.zijlstra@chello.nl, linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from dsl027-180-168.sfo1.dsl.speakeasy.net ([216.27.180.168]:13798 "EHLO sunset.davemloft.net") by vger.kernel.org with ESMTP id S1030410AbWHIBm2 (ORCPT ); Tue, 8 Aug 2006 21:42:28 -0400 To: phillips@google.com In-Reply-To: <44D93BEE.4000001@google.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Daniel Phillips Date: Tue, 08 Aug 2006 18:35:42 -0700 > David Miller wrote: > > I think the new atomic operation that will seemingly occur on every > > device SKB free is unacceptable. > > Alternate suggestion? Sorry, I have none. But you're unlikely to get your changes considered seriously unless you can avoid any new overhead your patch has which is of this level. We're busy trying to make these data structures smaller, and eliminate atomic operations, as much as possible. Therefore anything which adds new datastructure elements and new atomic operations will be met with fierce resistence unless it results an equal or greater shrink of datastructures elsewhere or removes atomic operations elsewhere in the critical path.