netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Jesse Brandeburg <jesse.brandeburg@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, chris.leech@gmail.com, "Brandeburg,
	Jesse" <jesse.brandeburg@intel.com>
Subject: Re: [RFC] avoid unnecessary alignement overhead in skb->data allocation.
Date: Tue, 8 Aug 2006 09:24:08 +0400	[thread overview]
Message-ID: <20060808052408.GA7279@2ka.mipt.ru> (raw)
In-Reply-To: <4807377b0608071709j26da1092la20f1589c7b90df7@mail.gmail.com>

On Mon, Aug 07, 2006 at 05:09:39PM -0700, Jesse Brandeburg (jesse.brandeburg@gmail.com) wrote:
> LPE controls whether long packet reception is permitted. Hardware
> discards long packets if LPE is 0. A long packet is one longer than
> 1522 bytes. If LPE is 1, the maximum packet size that the device can
> receive is 16384 bytes.

So there is no place at the end of skb for additional pointer.
And new question arises - until what Jesse suggested is implemented in
some way, do we need to store a pointer to shared info inside skb and
allocate it from cache in case it does no fit into aligned buffer (in
case of e1000 it happens all the time exept 1500 MTU)?
David, Herbert?

-- 
	Evgeniy Polyakov

  parent reply	other threads:[~2006-08-08  5:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07  6:01 [RFC] avoid unnecessary alignement overhead in skb->data allocation Evgeniy Polyakov
2006-08-07  6:23 ` David Miller
2006-08-07  6:30   ` Evgeniy Polyakov
2006-08-07  7:17   ` Herbert Xu
2006-08-07  7:24     ` Evgeniy Polyakov
2006-08-07  7:28       ` Herbert Xu
2006-08-07  7:31         ` Evgeniy Polyakov
2006-08-07  7:39           ` Herbert Xu
2006-08-08  0:09             ` Jesse Brandeburg
2006-08-08  0:41               ` David Miller
2006-08-08  5:24               ` Evgeniy Polyakov [this message]
2006-08-08  5:41                 ` Herbert Xu
2006-08-08  5:55                   ` Evgeniy Polyakov
2006-08-07  6:29 ` Herbert Xu
2006-08-07  6:36   ` Evgeniy Polyakov
2006-08-07  6:42     ` Herbert Xu
2006-08-07  8:05 ` Eric Dumazet
2006-08-07  8:14   ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060808052408.GA7279@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=chris.leech@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jesse.brandeburg@gmail.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).