From: louis.nyffenegger@gmail.com
To: netdev@vger.kernel.org
Subject: remove is_setbyuser patch
Date: Tue, 8 Aug 2006 10:02:31 +0200 [thread overview]
Message-ID: <20060808080231.GB13512@prozac> (raw)
The same without gmail problems
== Changelog ==
The value is_setbyuser from struct ip_options is never used and set
only one time (http://linux-net.osdl.org/index.php/TODO#IPV4).
This little patch removes it from the kernel source.
Signed-off-by: Louis Nyffenegger <louis.nyffenegger@gmail.com>
== Patch ==
--- /usr/src/linux/include/net/inet_sock.h.orig 2006-08-07 17:44:18.000000000 +0200
+++ /usr/src/linux/include/net/inet_sock.h 2006-08-07 17:44:49.000000000 +0200
@@ -28,7 +28,6 @@
/** struct ip_options - IP Options
*
* @faddr - Saved first hop address
- * @is_setbyuser - Set by setsockopt?
* @is_data - Options in __data, rather than skb
* @is_strictroute - Strict source route
* @srr_is_hit - Packet destination addr was our one
@@ -43,8 +42,7 @@ struct ip_options {
unsigned char srr;
unsigned char rr;
unsigned char ts;
- unsigned char is_setbyuser:1,
- is_data:1,
+ unsigned char is_data:1,
is_strictroute:1,
srr_is_hit:1,
is_changed:1,
--- /usr/src/linux/net/ipv4/ip_options.c.orig 2006-08-07 17:45:12.000000000 +0200
+++ /usr/src/linux/net/ipv4/ip_options.c 2006-08-07 17:45:23.000000000 +0200
@@ -507,7 +507,6 @@ static int ip_options_get_finish(struct
opt->__data[optlen++] = IPOPT_END;
opt->optlen = optlen;
opt->is_data = 1;
- opt->is_setbyuser = 1;
if (optlen && ip_options_compile(opt, NULL)) {
kfree(opt);
return -EINVAL;
next reply other threads:[~2006-08-08 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 8:02 louis.nyffenegger [this message]
2006-08-08 7:56 ` remove is_setbyuser patch David Miller
-- strict thread matches above, loose matches on Subject: below --
2006-08-08 7:02 Louis Nyffenegger
2006-08-08 7:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808080231.GB13512@prozac \
--to=louis.nyffenegger@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).