From: Stephen Hemminger <shemminger@osdl.org>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] llc: SOCK_DGRAM interface fixes
Date: Tue, 8 Aug 2006 09:42:10 -0700 [thread overview]
Message-ID: <20060808094210.34afd2a5@localhost.localdomain> (raw)
In-Reply-To: <20060808163618.GA1992@ms2.inr.ac.ru>
On Tue, 8 Aug 2006 20:36:18 +0400
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> wrote:
> Hello!
>
> > This fix goes against the old historical comments about UNIX98 semantics
> > but without this fix SOCK_DGRAM is broken and useless. So either ANK's
> > interpretation was incorect or UNIX98 standard was wrong.
>
> Just found this reference to me. :-)
>
> The comment migrated from tcp.c. It is only about connected SOCK_STREAM
> sockets, I do not see how it can make SOCK_DGRAM broken or useless.
The code was in the place where the source information was being copied
from the data portion to the cb portion of the skb. The original code
did the save only for SOCK_STREAM.
The cb portion is needed later to produce the address portion of the
receive handling which is critical with SOCK_DGRAM in LLC.
> That UNIX98 statement allowed to avoid expensive callback to protocol
> specific setup of address in tcp_recvmsg().
So the comment made sense for TCP but not LLC.
--
next prev parent reply other threads:[~2006-08-08 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 16:21 [PATCH] llc: SOCK_DGRAM interface fixes Stephen Hemminger
2006-08-03 16:38 ` Arnaldo Carvalho de Melo
2006-08-03 23:39 ` David Miller
2006-08-03 21:52 ` [stable] " Greg KH
2006-08-08 16:36 ` Alexey Kuznetsov
2006-08-08 16:42 ` Stephen Hemminger [this message]
2006-08-08 17:54 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808094210.34afd2a5@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).