* [PATCH] sky2: phy power problems on 88e805X chips
@ 2006-08-09 21:14 Stephen Hemminger
2006-08-10 12:32 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2006-08-09 21:14 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
On the 88E805X chipsets (used in laptops), the PHY was not getting powered
out of shutdown properly. The variable reg1 was getting reused incorrectly.
This is probably the cause of the bug.
http://bugzilla.kernel.org/show_bug.cgi?id=6471
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- netdev-2.6.orig/drivers/net/sky2.c 2006-08-09 14:13:36.000000000 -0700
+++ netdev-2.6/drivers/net/sky2.c 2006-08-09 14:14:07.000000000 -0700
@@ -233,6 +233,8 @@
if (hw->ports > 1)
reg1 |= PCI_Y2_PHY2_COMA;
}
+ sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
+ udelay(100);
if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
sky2_pci_write32(hw, PCI_DEV_REG3, 0);
@@ -242,9 +244,6 @@
sky2_pci_write32(hw, PCI_DEV_REG5, 0);
}
- sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
- udelay(100);
-
break;
case PCI_D3hot:
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sky2: phy power problems on 88e805X chips
2006-08-09 21:14 [PATCH] sky2: phy power problems on 88e805X chips Stephen Hemminger
@ 2006-08-10 12:32 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-08-10 12:32 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Stephen Hemminger wrote:
> On the 88E805X chipsets (used in laptops), the PHY was not getting powered
> out of shutdown properly. The variable reg1 was getting reused incorrectly.
> This is probably the cause of the bug.
> http://bugzilla.kernel.org/show_bug.cgi?id=6471
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> --- netdev-2.6.orig/drivers/net/sky2.c 2006-08-09 14:13:36.000000000 -0700
> +++ netdev-2.6/drivers/net/sky2.c 2006-08-09 14:14:07.000000000 -0700
> @@ -233,6 +233,8 @@
> if (hw->ports > 1)
> reg1 |= PCI_Y2_PHY2_COMA;
> }
> + sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
> + udelay(100);
>
> if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
applied to #upstream-fixes, though I note that the obvious PCI posting
bug remains.
You cannot be assured that the udelay(100) is truly effective without a
flushing readl().
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-10 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-09 21:14 [PATCH] sky2: phy power problems on 88e805X chips Stephen Hemminger
2006-08-10 12:32 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).