Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

[David Miller <davem@davemloft.net>]

From: "Jesper Juhl" <jesper.juhl@gmail.com>
Date: Fri, 11 Aug 2006 00:18:44 +0200

> Hmm, perhaps I'm going blind, but I don't see it.

I definitely screwed that changeset up somehow.  Thanks for catching
this.

Somehow James's fix got clobbered into just my subsequent warning fix,
like this:

commit 118075b3cdc90e0815362365f3fc64d672ace0d6
Author: James Morris <jmorris@namei.org>
Date:   Sun Jul 30 20:21:45 2006 -0700

    [TCP]: fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()
    
    Based upon a patch by Jesper Juhl.
    
    Signed-off-by: James Morris <jmorris@namei.org>
    Acked-by: Stephen Hemminger <shemminger@osdl.org>
    Acked-by: Jesper Juhl <jesper.juhl@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
index d7d517a..b343532 100644
--- a/net/ipv4/tcp_probe.c
+++ b/net/ipv4/tcp_probe.c
@@ -114,7 +114,7 @@ static int tcpprobe_open(struct inode * 
 static ssize_t tcpprobe_read(struct file *file, char __user *buf,
 			     size_t len, loff_t *ppos)
 {
-	int error = 0, cnt;
+	int error = 0, cnt = 0;
 	unsigned char *tbuf;
 
 	if (!buf || len < 0)

Anyways, I'll fix this up, thanks again.