From: Andrew Morton <akpm@osdl.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: David Miller <davem@davemloft.net>,
Paul McKenney <paulmck@us.ibm.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/5] socket: code style cleanup
Date: Thu, 10 Aug 2006 01:19:50 -0700 [thread overview]
Message-ID: <20060810011950.0a56760a.akpm@osdl.org> (raw)
In-Reply-To: <20060809183349.177095462@localhost.localdomain>
On Wed, 09 Aug 2006 11:31:40 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> Make socket.c conform to current style:
> * run through Lindent
> * get rid of unneeded casts
> * split assignment and comparsion where possible
>
<stares at a stream of rejects. Sighs>
> -static ssize_t sock_aio_read(struct kiocb *iocb, char __user *buf,
> - size_t size, loff_t pos);
> -static ssize_t sock_aio_write(struct kiocb *iocb, const char __user *buf,
> - size_t size, loff_t pos);
> -static int sock_mmap(struct file *file, struct vm_area_struct * vma);
> +static ssize_t sock_aio_read(struct kiocb *iocb, char __user * buf,
> + size_t size, loff_t pos);
> +static ssize_t sock_aio_write(struct kiocb *iocb, const char __user * buf,
> + size_t size, loff_t pos);
> +static int sock_mmap(struct file *file, struct vm_area_struct *vma);
The s/ *buf/ * buf/ is inconsistent, illogical and, IMO, wrong.
<goes off to fix the rejects>
next prev parent reply other threads:[~2006-08-10 8:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 18:31 [PATCH 0/5] net socket family patches Stephen Hemminger
2006-08-09 18:31 ` [PATCH 1/5] sock_create bad error return Stephen Hemminger
2006-08-10 3:47 ` David Miller
2006-08-10 17:06 ` Stephen Hemminger
2006-08-09 18:31 ` [PATCH 2/5] socket: code style cleanup Stephen Hemminger
2006-08-10 3:49 ` David Miller
2006-08-10 8:19 ` Andrew Morton [this message]
2006-08-10 8:55 ` David Miller
2006-08-09 18:31 ` [PATCH 3/5] net: drop unused elements from net_proto_family Stephen Hemminger
2006-08-10 3:50 ` David Miller
2006-08-09 18:31 ` [PATCH 4/5] net: socket family using RCU Stephen Hemminger
2006-08-10 4:00 ` David Miller
2006-08-10 18:36 ` Paul E. McKenney
2006-08-10 20:28 ` Stephen Hemminger
2006-08-11 0:46 ` Paul E. McKenney
2006-08-09 18:31 ` [PATCH 5/5] sock_register interface changes Stephen Hemminger
2006-08-10 4:03 ` David Miller
2006-08-10 0:06 ` [PATCH 0/5] net socket family patches David Miller
2006-08-10 5:36 ` Alexey Toptygin
2006-08-10 18:55 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810011950.0a56760a.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).