From: Thomas Graf <tgraf@suug.ch>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb()
Date: Thu, 10 Aug 2006 21:02:10 +0200 [thread overview]
Message-ID: <20060810190210.GH14627@postel.suug.ch> (raw)
In-Reply-To: <20060810155120.GA494@ms2.inr.ac.ru>
* Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> 2006-08-10 19:51
> > This patch handles NLM_F_ECHO in netlink_rcv_skb() to
> > handle it in a central point. Most subsystems currently
> > interpret NLM_F_ECHO as to just unicast events to the
> > originator of the change while the real meaning of the
> > flag is to echo the request.
>
> Do not you think it is useless to echo something back to originator,
> who just sent it?
>
> Actually, the sense of NLM_F_ECHO was to tell user what happened due to
> his request. The answer is not original request, which can contain
> some incomplete fields etc., but full information about object
> deleted/added/changed. Moreover, the feedback can contain several
> messages (though accurately it is done only in net/sched/), f.e. when
> the request triggered deletion of one object and addition of another.
>
> Obviously, it cannot be done in a central place.
>
> Normally, it is not needed, "ip route add" does not tell user, what
> actually was done, so that it suppresses echo. But for multistage
> operation it is absolutely necessary: the answer contains f.e. auto-allocated
> handles, which should be given in subsequent requests.
What's wrong with listening to the notification for that purpose?
next prev parent reply other threads:[~2006-08-10 19:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 20:48 [PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications Thomas Graf
2006-08-08 22:00 ` [PATCH 1/4] [NETLINK]: Handle NLM_F_ECHO in netlink_rcv_skb() Thomas Graf
2006-08-10 15:51 ` Alexey Kuznetsov
2006-08-10 19:02 ` Thomas Graf [this message]
2006-08-10 20:32 ` Alexey Kuznetsov
2006-08-10 21:18 ` Thomas Graf
2006-08-11 15:35 ` Alexey Kuznetsov
2006-08-11 21:47 ` Thomas Graf
2006-08-12 11:03 ` Alexey Kuznetsov
2006-08-12 11:19 ` Thomas Graf
2006-08-13 13:45 ` Alexey Kuznetsov
2006-08-12 3:05 ` Herbert Xu
2006-08-12 11:05 ` Alexey Kuznetsov
2006-08-08 22:00 ` [PATCH 2/4] [RTNETLINK]: Use rtnl_multicast()/rtnl_unicast() Thomas Graf
2006-08-09 21:00 ` [RESEND " Thomas Graf
2006-08-08 22:00 ` [PATCH 3/4] [NETLINK]: Dont set socket error for failed event notifications Thomas Graf
2006-08-10 18:09 ` Patrick McHardy
2006-08-10 19:04 ` Thomas Graf
2006-08-10 19:08 ` Patrick McHardy
2006-08-10 19:23 ` Thomas Graf
2006-08-11 6:02 ` David Miller
2006-08-11 10:38 ` Thomas Graf
2006-08-11 10:42 ` David Miller
2006-08-08 22:00 ` [PATCH 4/4] [RTNETLINK]: Unexport global rtnl sock Thomas Graf
2006-08-10 4:16 ` [PATCHSET]: Clean up netlink NLM_F_ECHO and rtnl event notifications David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810190210.GH14627@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).