From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: skb_shared_info()
Date: Thu, 10 Aug 2006 23:49:14 +0400 [thread overview]
Message-ID: <20060810194914.GA29976@2ka.mipt.ru> (raw)
In-Reply-To: <20060808.163915.03600382.davem@davemloft.net>
On Tue, Aug 08, 2006 at 04:39:15PM -0700, David Miller (davem@davemloft.net) wrote:
>
> I'm beginning to think that where we store the
> skb_shared_info() is a weakness of the SKB design.
Food for thoughts - unix sockets can use PAGE_SIZEd chunks of memory
(and they do it almost always), which are aligned to 2*PAGE_SIZE due to
alignment issues with skb_shared_info, so unix sockets waste 3.5 kb of
memory on each skb. I think it is time to resurrect idea of placing
shared_info inside skb and allow to allocate it from own cache for
special cases, what do you think?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2006-08-10 19:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 23:39 skb_shared_info() David Miller
2006-08-09 0:36 ` skb_shared_info() Herbert Xu
2006-08-09 0:58 ` skb_shared_info() David Miller
2006-08-09 5:35 ` skb_shared_info() Evgeniy Polyakov
2006-08-09 5:50 ` skb_shared_info() David Miller
2006-08-10 19:49 ` Evgeniy Polyakov [this message]
2006-08-11 14:00 ` skb_shared_info() Alexey Kuznetsov
2006-08-12 0:27 ` skb_shared_info() David Miller
2006-08-12 0:32 ` skb_shared_info() Herbert Xu
2006-08-13 13:04 ` skb_shared_info() Alexey Kuznetsov
2006-08-14 8:01 ` skb_shared_info() Evgeniy Polyakov
2006-08-14 13:19 ` skb_shared_info() Alexey Kuznetsov
2006-08-14 13:38 ` skb_shared_info() Evgeniy Polyakov
2006-08-15 11:30 ` skb_shared_info() Alexey Kuznetsov
2006-08-14 5:04 ` skb_shared_info() Andi Kleen
2006-08-14 7:29 ` skb_shared_info() Herbert Xu
2006-08-14 7:45 ` skb_shared_info() Andi Kleen
2006-08-14 7:50 ` skb_shared_info() Herbert Xu
2006-08-14 8:18 ` skb_shared_info() Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810194914.GA29976@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).