Re: [DECNET] Fix to multiple tables routing

[Steven Whitehouse <steve@chygwyn.com>]

Hi,

On Fri, Aug 11, 2006 at 05:22:17PM +0200, Patrick McHardy wrote:
> Steven Whitehouse wrote:
> > Here is a fix to Patrick McHardy's increase number of routing tables patch
> > for DECnet. I did just test this and it appears to be working fine with
> > this patch.
> > 
> > Cc: Patrick McHardy <kaber@trash.net>
> > Cc: Patrick Caulfield <patrick@tykepenguin.com>
> > Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
> > 
> > diff --git a/net/decnet/dn_rules.c b/net/decnet/dn_rules.c
> > index 878312f..c8d9411 100644
> > --- a/net/decnet/dn_rules.c
> > +++ b/net/decnet/dn_rules.c
> > @@ -116,6 +116,7 @@ static struct nla_policy dn_fib_rule_pol
> >  	[FRA_SRC]	= { .type = NLA_U16 },
> >  	[FRA_DST]	= { .type = NLA_U16 },
> >  	[FRA_FWMARK]	= { .type = NLA_U32 },
> > +	[FRA_TABLE]     = { .type = NLA_U32 },
> >  };
> 
> Looks good. BTW, I noticed something in the DecNET fib_rule conversion
> that looks like a bug:
> 
> The policy includes this for FRA_SRC/FRA_DST:
> 
>         [FRA_SRC]       = { .type = NLA_U16 },
>         [FRA_DST]       = { .type = NLA_U16 },
> 
> But in dn_fib_rule_compare it is used like this:
> 
>         if (tb[FRA_SRC] && (r->src != nla_get_u32(tb[FRA_SRC])))
>                 return 0;
> 
>         if (tb[FRA_DST] && (r->dst != nla_get_u32(tb[FRA_DST])))
>                 return 0;
> 
> I think this might create problems depending on the endianness.

Yes, good spotting :-) I'll send a patch shortly,

Steve.