Re: 2.6.18-rc3-mm2 (+ hotfixes): GPF related to skge on suspend

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Saturday 12 August 2006 18:12, Edgar E. Iglesias wrote:
> On Sat, Aug 12, 2006 at 04:31:18PM +0200, Rafael J. Wysocki wrote:
> > On Saturday 12 August 2006 14:28, Andrew Morton wrote:
> > > On Sat, 12 Aug 2006 12:07:42 +0200
> > > "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > > 
> > > > Hi,
> > > > 
> > > > On 2.6.18-rc3-mm2 with hotfixes I get things like the appended one on attempts
> > > > to suspend to disk.  It occurs while devices are being suspended and is fairly
> > > > reproducible.
> > > > 
> > > > Greetings,
> > > > Rafael
> > > > 
> > > > 
> > > > Suspending device 0000:01:00.0
> > > > Suspending device 0000:02:02.0
> > > > Suspending device 0000:02:01.4
> > > > Suspending device 0000:02:01.3
> > > > Suspending device 0000:02:01.2
> > > > Suspending device 0000:02:01.1
> > > > Suspending device 0000:02:01.0
> > > > Suspending device 0000:02:00.0
> > > > skge Ram read data parity error
> > > > skge Ram write data parity error
> > > > skge eth0: receive queue parity error
> > > > skge <NULL>: receive queue parity error
> > 
> > This stuff comes from the interrupt handler which apparently races with
> > something.
> 
> Maybe the skge driver is not doing netif_poll_disable before clearing the rx 
> ring at suspend/down?

Apparently it doesn't.

At least netif_poll_disable is not referenced anywhere in skge.c .

Greetings,
Rafael