From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: greg@kroah.com, nix@esperi.org.uk, linux-kernel@vger.kernel.org,
neilb@suse.de, netdev@vger.kernel.org
Subject: Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming
Date: Sun, 13 Aug 2006 20:19:34 -0700 (PDT) [thread overview]
Message-ID: <20060813.201934.32734362.davem@davemloft.net> (raw)
In-Reply-To: <20060813125910.GA18463@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 13 Aug 2006 22:59:11 +1000
> On Sat, Aug 12, 2006 at 09:19:19PM +0000, Nix wrote:
> >
> > The kernel log showed a heap of BUGs from somewhere inside the skb
> > management layer, somewhere in UDP fragment processing while
> > handling NFS requests. It starts like this:
> >
> > Aug 12 21:31:08 hades warning: kernel: BUG: warning at include/linux/skbuff.h:975/__skb_trim()
> > Aug 12 21:31:08 hades warning: kernel: <c030ed39> ip_append_data+0x5b3/0x951 <c030fc18> ip_generic_getfrag+0x0/0x96
>
> Oops, I missed this code path when I disallowed skb_trim from operating
> on a paged skb. This patch should fix the problem.
>
> Greg, we need this for 2.6.17 stable as well if Dave is OK with it.
>
> [INET]: Use pskb_trim_unique when trimming paged unique skbs
...
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Looks good, Greg please push to -stable. I'll push this into
2.6.18 under seperate cover.
next prev parent reply other threads:[~2006-08-14 3:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 21:19 [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming Nix
2006-08-12 22:17 ` Nix
2006-08-13 12:29 ` Nix
2006-08-13 12:59 ` Herbert Xu
2006-08-13 18:24 ` Nix
2006-08-14 3:19 ` David Miller [this message]
2006-08-25 23:03 ` Greg KH
2006-08-26 1:18 ` Herbert Xu
2006-09-06 20:47 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060813.201934.32734362.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).