From: "Jouni Malinen" <jkm@devicescape.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Jiri Benc <jbenc@suse.cz>
Subject: Re: [PATCH] d80211: fix some 0 vs. NULL comparisons
Date: Mon, 14 Aug 2006 08:48:13 -0700 [thread overview]
Message-ID: <20060814154813.GA1196@instant802.com> (raw)
In-Reply-To: <44E078BA.5010707@sipsolutions.net>
On Mon, Aug 14, 2006 at 03:20:58PM +0200, Johannes Berg wrote:
> Johannes Berg wrote:
> >- if (!local->hw->passive_scan) {
> >+ if (local->hw->passive_scan == NULL) {
>
> Alright, this is icky. I'll make another pass and change it all to if
> (x) or if (!x) instead of comparing to NULL. Don't hold your breath
> though, earliest next weekend.
Well.. I'm perfectly fine with comparing function pointers to NULL in
this kind of case.. In many cases, I find fp == NULL to be clearer than
!fp, but for the fp != NULL case I would rather not see != NULL.. Not
very consistent, but can't really help with that on this kind of coding
style opinions. Anyway, replacing 0 with NULL is a good change.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2006-08-14 15:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 8:07 [wireless] bunch of questions and notes on d80211 Johannes Berg
2006-08-14 8:10 ` bcm43xx for d80211 softirq loop Johannes Berg
[not found] ` <44E0300D.1000402-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2006-08-14 8:21 ` Johannes Berg
2006-08-14 13:27 ` Michael Buesch
2006-08-14 8:12 ` [d80211 rfc] link master interface from wiphy Johannes Berg
2006-08-14 12:01 ` Dan Williams
2006-08-16 17:05 ` Jiri Benc
2006-08-17 7:18 ` Johannes Berg
2006-08-14 8:13 ` [PATCH] d80211: fix some 0 vs. NULL comparisons Johannes Berg
2006-08-14 13:20 ` Johannes Berg
2006-08-14 15:48 ` Jouni Malinen [this message]
2006-08-14 8:15 ` [PATCH] d80211: get rid of the WME bitfield Johannes Berg
2006-08-14 16:12 ` Jouni Malinen
2006-08-15 7:11 ` Johannes Berg
2006-08-14 8:16 ` ieee80211_japan_5ghz / firmware etc.?? Johannes Berg
2006-08-14 8:16 ` ieee80211_set_encryption Johannes Berg
2006-08-14 15:53 ` ieee80211_set_encryption Jouni Malinen
2006-08-14 8:18 ` network manager confused with bcm43xx-d80211? Johannes Berg
2006-08-14 11:46 ` Dan Williams
2006-08-14 12:28 ` Johannes Berg
2006-08-14 12:48 ` Larry Finger
2006-08-14 12:54 ` Johannes Berg
2006-08-14 8:19 ` d80211 and sta_aid for AP functionality Johannes Berg
2006-08-17 18:21 ` Jiri Benc
2006-08-14 8:22 ` wlan#ap seems bogus Johannes Berg
2006-08-14 14:04 ` Johannes Berg
2006-08-14 18:53 ` Simon Barber
2006-08-15 7:22 ` Johannes Berg
2006-08-14 15:58 ` Jouni Malinen
2006-08-14 16:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814154813.GA1196@instant802.com \
--to=jkm@devicescape.com \
--cc=jbenc@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).