From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: netdev@vger.kernel.org, mb@bu3sch.de
Subject: Re: [PATCH] Remove ugly TODO output from log files in bcm43xx-softmac
Date: Mon, 14 Aug 2006 14:55:02 -0400 [thread overview]
Message-ID: <20060814185456.GB13934@tuxdriver.com> (raw)
In-Reply-To: <44DA4FF5.4020507@lwfinger.net>
On Wed, Aug 09, 2006 at 04:13:25PM -0500, Larry Finger wrote:
> This patch removes the ugly TODO output from the logs for bcm43xx-softmac.
> The
> patch is for the latest version of Linville's wireless-2.6 tree.
I'm not sure if this is the right approach. In fact I know it isn't --
the right approach would be to implement the missing code! :-)
But barring that, wouldn't it be better to change the TODO() macro
to key off a build-time definition like CONFIG_BCM43XX_DEBUG?
Michael, what do you think?
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2006-08-14 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 21:13 [PATCH] Remove ugly TODO output from log files in bcm43xx-softmac Larry Finger
2006-08-14 18:55 ` John W. Linville [this message]
2006-08-14 19:51 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814185456.GB13934@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).