From: Thomas Graf <tgraf@suug.ch>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: [PATCH 15/16] [NET] link: Convert notifications to use rtnl_notify()
Date: Mon, 14 Aug 2006 00:00:15 +0200 [thread overview]
Message-ID: <20060814214343.781776800@postel.suug.ch> (raw)
In-Reply-To: 20060814213718.580598840@postel.suug.ch
[-- Attachment #1: rtnl_convert_link --]
[-- Type: text/plain, Size: 1196 bytes --]
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Index: net-2.6.19.git/net/core/rtnetlink.c
===================================================================
--- net-2.6.19.git.orig/net/core/rtnetlink.c
+++ net-2.6.19.git/net/core/rtnetlink.c
@@ -630,20 +630,22 @@ static int rtnl_dump_all(struct sk_buff
void rtmsg_ifinfo(int type, struct net_device *dev, unsigned change)
{
struct sk_buff *skb;
- int size = NLMSG_SPACE(sizeof(struct ifinfomsg) +
- sizeof(struct rtnl_link_ifmap) +
- sizeof(struct rtnl_link_stats) + 128);
-
- skb = nlmsg_new(size, GFP_KERNEL);
- if (!skb)
- return;
+ int err = -ENOBUFS;
- if (rtnl_fill_ifinfo(skb, dev, NULL, 0, type, 0, 0, change, 0) < 0) {
+ skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
+ if (skb == NULL)
+ goto errout;
+
+ err = rtnl_fill_ifinfo(skb, dev, NULL, 0, type, 0, 0, change, 0);
+ if (err < 0) {
kfree_skb(skb);
- return;
+ goto errout;
}
- NETLINK_CB(skb).dst_group = RTNLGRP_LINK;
- netlink_broadcast(rtnl, skb, 0, RTNLGRP_LINK, GFP_KERNEL);
+
+ err = rtnl_notify(skb, 0, RTNLGRP_LINK, NULL, GFP_KERNEL);
+errout:
+ if (err < 0)
+ rtnl_set_sk_err(RTNLGRP_LINK, err);
}
/* Protected by RTNL sempahore. */
next prev parent reply other threads:[~2006-08-14 21:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-14 21:37 [PATCHSET] rtnetlink notification rework Thomas Graf
2006-08-13 22:00 ` [PATCH 01/16] [RTNETLINK]: Use rtnl_unicast() for rtnetlink unicasts Thomas Graf
2006-08-13 22:00 ` [PATCH 02/16] [NETLINK]: Add notification message sending interface Thomas Graf
2006-08-13 22:00 ` [PATCH 03/16] [RTNETLINK]: Add rtnetlink notification interface Thomas Graf
2006-08-13 22:00 ` [PATCH 04/16] [NET] fib_rules: Convert fib rule notification to use rtnl_notify() Thomas Graf
2006-08-13 22:00 ` [PATCH 05/16] [NEIGH]: Convert neighbour notifications ot " Thomas Graf
2006-08-13 22:00 ` [PATCH 06/16] [DECNET]: Convert DECnet notifications to " Thomas Graf
2006-08-13 22:00 ` [PATCH 07/16] [IPv4] address: Convert address notification " Thomas Graf
2006-08-13 22:00 ` [PATCH 08/16] [IPv4] route: Convert route notifications " Thomas Graf
2006-08-13 22:00 ` [PATCH 09/16] [IPv6] address: Convert address notification " Thomas Graf
2006-08-14 23:43 ` jamal
2006-08-14 23:51 ` jamal
2006-08-15 7:20 ` Hasso Tepper
2006-08-15 9:50 ` jamal
2006-08-15 0:07 ` Thomas Graf
2006-08-15 0:12 ` jamal
2006-08-15 0:36 ` Alexey Kuznetsov
2006-08-15 0:56 ` Herbert Xu
2006-08-15 2:46 ` jamal
2006-08-15 3:03 ` jamal
2006-08-15 11:17 ` Thomas Graf
2006-08-15 12:08 ` Hasso Tepper
2006-08-15 12:23 ` Thomas Graf
2006-08-16 2:58 ` Herbert Xu
2006-08-16 3:04 ` Herbert Xu
2006-08-16 10:58 ` Thomas Graf
2006-08-16 11:03 ` jamal
2006-08-16 11:12 ` Herbert Xu
2006-08-16 11:39 ` Herbert Xu
2006-08-16 12:04 ` jamal
2006-08-16 12:08 ` Herbert Xu
2006-08-16 12:08 ` Thomas Graf
2006-08-16 12:36 ` jamal
2006-08-16 13:04 ` Alexey Kuznetsov
2006-08-16 13:11 ` jamal
2006-08-16 12:13 ` Thomas Graf
2006-08-16 11:40 ` Thomas Graf
2006-08-16 11:57 ` Herbert Xu
2006-08-16 12:05 ` Thomas Graf
2006-08-16 12:08 ` jamal
2006-08-16 12:54 ` Alexey Kuznetsov
2006-08-13 22:00 ` [PATCH 10/16] [IPv6] route: Convert route notifications " Thomas Graf
2006-08-13 22:00 ` [PATCH 11/16] [IPv6] link: Convert link " Thomas Graf
2006-08-13 22:00 ` [PATCH 12/16] [IPv6] prefix: Convert prefix " Thomas Graf
2006-08-13 22:00 ` [PATCH 13/16] [BRIDGE]: Convert " Thomas Graf
2006-08-13 22:00 ` [PATCH 14/16] [WIRELESS]: " Thomas Graf
2006-08-13 22:00 ` Thomas Graf [this message]
2006-08-13 22:00 ` [PATCH 16/16] [RTNETLINK]: Unexport rtnl socket Thomas Graf
2006-08-15 7:38 ` [PATCHSET] rtnetlink notification rework David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060814214343.781776800@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).