From: David Miller <davem@davemloft.net>
To: dlstevens@us.ibm.com
Cc: kuznet@ms2.inr.ac.ru, michal.ruzicka@comstar.cz,
netdev@vger.kernel.org, netdev-owner@vger.kernel.org
Subject: Re: Possible leak of multicast source filter sctructure
Date: Tue, 15 Aug 2006 00:21:39 -0700 (PDT) [thread overview]
Message-ID: <20060815.002139.107685177.davem@davemloft.net> (raw)
In-Reply-To: <OF76CDD1A8.A722B591-ON882571CA.00781509-882571CA.007980C0@us.ibm.com>
From: David Stevens <dlstevens@us.ibm.com>
Date: Mon, 14 Aug 2006 15:07:08 -0700
> The first patch in that, yes.
>
> Acked-by: David L Stevens <dlstevens@us.ibm.com>
I've applied it and will push to net-2.6.18
> I'm not sure the second one is quite right. The case of concern
> is where an interface is deleted. If you joined (or left) the group by
> address and then deleted the interface, then you wouldn't match the
> index (which wouldn't be set) so the leave wouldn't work, still.
> Also, if you passed a completely bogus ifindex, it should return
> ENODEV, but with the patch it would return EADDRNOTAVAIL it appears.
> So, I think the second patch needs some more work. I'll look at
> it some more and see if I can suggest something better.
Ok, this second patch does need to be refined a little bit.
next prev parent reply other threads:[~2006-08-15 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 11:04 Possible leak of multicast source filter sctructure Michal Ruzicka
2006-08-14 3:44 ` David Miller
2006-08-14 22:07 ` David Stevens
2006-08-15 7:21 ` David Miller [this message]
2006-08-15 23:57 ` [PATCH] " David Stevens
2006-08-17 23:29 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2006-08-17 12:26 Michal Ruzicka
2006-08-17 15:26 ` David Stevens
2006-08-14 10:56 Michal Ruzicka
2006-08-09 10:56 [RFC] [GIT PATCH] IPv6 Routing / Ndisc Fixes YOSHIFUJI Hideaki / 吉藤英明
[not found] ` <44D9D431.10101@tcs.hut.fi>
2006-08-09 21:37 ` Ville Nuorvala
2006-08-10 8:46 ` YOSHIFUJI Hideaki / 吉藤英明
2006-08-10 10:20 ` Ville Nuorvala
2006-08-10 12:07 ` Possible leak of multicast source filter sctructure Michal Ruzicka
2006-08-10 12:12 ` David Miller
2006-08-10 12:13 ` David Miller
2006-08-10 18:07 ` David Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815.002139.107685177.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=michal.ruzicka@comstar.cz \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).