From: Adrian Bunk <bunk@stusta.de>
To: proski@gnu.org, hermes@gibson.dropbear.id.au
Cc: orinoco-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linville@tuxdriver.com, jgarzik@pobox.com
Subject: [2.6 patch] orinoco.h: "extern inline" -> "static __always_inline"
Date: Tue, 15 Aug 2006 02:40:46 +0200 [thread overview]
Message-ID: <20060815004046.GC3543@stusta.de> (raw)
"extern inline" generates a warning with -Wmissing-prototypes and I'm
currently working on getting the kernel cleaned up for adding this to
the CFLAGS since it will help us to avoid a nasty class of runtime
errors.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/net/wireless/orinoco.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.18-rc4-mm1/drivers/net/wireless/orinoco.h.old 2006-08-13 23:14:05.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/net/wireless/orinoco.h 2006-08-13 23:14:39.000000000 +0200
@@ -138,8 +138,8 @@
* SPARC, due to its weird semantics for save/restore flags. extern
* inline should prevent the kernel from linking or module from
* loading if they are not inlined. */
-extern inline int orinoco_lock(struct orinoco_private *priv,
- unsigned long *flags)
+static __always_inline int orinoco_lock(struct orinoco_private *priv,
+ unsigned long *flags)
{
spin_lock_irqsave(&priv->lock, *flags);
if (priv->hw_unavailable) {
@@ -151,8 +151,8 @@
return 0;
}
-extern inline void orinoco_unlock(struct orinoco_private *priv,
- unsigned long *flags)
+static __always_inline void orinoco_unlock(struct orinoco_private *priv,
+ unsigned long *flags)
{
spin_unlock_irqrestore(&priv->lock, *flags);
}
next reply other threads:[~2006-08-15 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 0:40 Adrian Bunk [this message]
2006-08-15 19:26 ` [2.6 patch] orinoco.h: "extern inline" -> "static __always_inline" Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815004046.GC3543@stusta.de \
--to=bunk@stusta.de \
--cc=hermes@gibson.dropbear.id.au \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).