From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: mitch.a.williams@intel.com, notting@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: bonding: cannot remove certain named devices
Date: Tue, 15 Aug 2006 16:23:21 -0700 [thread overview]
Message-ID: <20060815162321.03eaa2ee@localhost.localdomain> (raw)
In-Reply-To: <20060815.155612.111203542.davem@davemloft.net>
On Tue, 15 Aug 2006 15:56:12 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Tue, 15 Aug 2006 15:44:44 -0700
>
> > IMHO idiots who put space's in filenames should be ignored. As long
> > as the bonding code doesn't throw a fatal error, it has every right
> > to return "No such device" to the fool.
>
> I agree that whitespace in device names push the limits of sanity.
>
> But if we believe that, we should enforce it in dev_valid_name().
>
> Does anyone really mind if I add the whitespace check there?
That is a good idea since it protects other interfaces from possible problems.
next prev parent reply other threads:[~2006-08-15 23:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 19:48 bonding: cannot remove certain named devices Bill Nottingham
2006-08-15 20:39 ` Mitch Williams
2006-08-15 20:45 ` Bill Nottingham
2006-08-15 21:02 ` Stephen Hemminger
2006-08-15 21:49 ` Bill Nottingham
2006-08-15 22:41 ` Mitch Williams
2006-08-15 22:44 ` Stephen Hemminger
2006-08-15 22:56 ` David Miller
2006-08-15 23:23 ` Stephen Hemminger [this message]
2006-08-15 23:26 ` Mitch Williams
[not found] <6Kd5j-3Y7-3@gated-at.bofh.it>
[not found] ` <6KdRL-5xP-7@gated-at.bofh.it>
[not found] ` <6Ke1p-5N8-7@gated-at.bofh.it>
[not found] ` <6KekO-6u0-25@gated-at.bofh.it>
[not found] ` <6KeXv-7qe-17@gated-at.bofh.it>
[not found] ` <6KfTz-OX-11@gated-at.bofh.it>
[not found] ` <6KfTA-OX-15@gated-at.bofh.it>
2006-08-16 0:02 ` Bodo Eggert
2006-08-16 0:10 ` David Miller
2006-08-16 6:35 ` Giacomo A. Catenazzi
2006-08-16 13:38 ` Bill Nottingham
2006-08-16 13:59 ` Giacomo A. Catenazzi
2006-08-16 15:11 ` Bodo Eggert
2006-08-17 7:29 ` Xavier Bestel
2006-08-17 14:12 ` Bill Nottingham
2006-08-17 23:23 ` David Miller
2006-08-18 0:34 ` Alan Cox
2006-08-18 1:01 ` David Miller
2006-08-18 2:20 ` Bill Nottingham
2006-08-19 3:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815162321.03eaa2ee@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=notting@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).