From: Dave Jones <davej@redhat.com>
To: Pavel Roskin <proski@gnu.org>
Cc: netdev@vger.kernel.org, Adrian Bunk <bunk@stusta.de>
Subject: Re: [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock()
Date: Tue, 15 Aug 2006 18:50:12 -0400 [thread overview]
Message-ID: <20060815225012.GA7612@redhat.com> (raw)
In-Reply-To: <20060815192558.3590.63591.stgit@dv.roinet.com>
On Tue, Aug 15, 2006 at 03:25:58PM -0400, Pavel Roskin wrote:
> diff --git a/drivers/net/wireless/orinoco.h b/drivers/net/wireless/orinoco.h
> index 16db3e1..8fd9b32 100644
> --- a/drivers/net/wireless/orinoco.h
> +++ b/drivers/net/wireless/orinoco.h
> @@ -135,11 +135,9 @@ extern irqreturn_t orinoco_interrupt(int
> /********************************************************************/
>
> /* These functions *must* be inline or they will break horribly on
> - * SPARC, due to its weird semantics for save/restore flags. extern
> - * inline should prevent the kernel from linking or module from
> - * loading if they are not inlined. */
> -extern inline int orinoco_lock(struct orinoco_private *priv,
> - unsigned long *flags)
> + * SPARC, due to its weird semantics for save/restore flags. */
Didn't that get fixed up for SPARC a year or so back?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-08-15 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 19:25 [PATCH] Use __always_inline in orinoco_lock()/orinoco_unlock() Pavel Roskin
2006-08-15 22:50 ` Dave Jones [this message]
2006-08-15 22:54 ` David Miller
2006-08-15 23:14 ` Pavel Roskin
2006-08-15 23:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060815225012.GA7612@redhat.com \
--to=davej@redhat.com \
--cc=bunk@stusta.de \
--cc=netdev@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).