netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Leech <christopher.leech@intel.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 5/7] [I/OAT] Remove the use of writeq from the ioatdma driver
Date: Tue, 15 Aug 2006 17:53:46 -0700	[thread overview]
Message-ID: <20060816005345.8634.53777.stgit@gitlost.site> (raw)
In-Reply-To: <20060816005337.8634.70033.stgit@gitlost.site>

There's only one now anyway, and it's not in a performance path,
so make it behave the same on 32-bit and 64-bit CPUs.

Signed-off-by: Chris Leech <christopher.leech@intel.com>
---

 drivers/dma/ioatdma.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c
index 0be426f..d6d817c 100644
--- a/drivers/dma/ioatdma.c
+++ b/drivers/dma/ioatdma.c
@@ -608,13 +608,11 @@ static void ioat_start_null_desc(struct 
 	list_add_tail(&desc->node, &ioat_chan->used_desc);
 	spin_unlock_bh(&ioat_chan->desc_lock);
 
-#if (BITS_PER_LONG == 64)
-	writeq(desc->phys, ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET);
-#else
-	writel((u32) desc->phys,
+	writel(((u64) desc->phys) & 0x00000000FFFFFFFF,
 	       ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET_LOW);
-	writel(0, ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET_HIGH);
-#endif
+	writel(((u64) desc->phys) >> 32,
+	       ioat_chan->reg_base + IOAT_CHAINADDR_OFFSET_HIGH);
+
 	writeb(IOAT_CHANCMD_START, ioat_chan->reg_base + IOAT_CHANCMD_OFFSET);
 }
 


  parent reply	other threads:[~2006-08-16  0:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-16  0:53 [PATCH 1/7] [I/OAT] Push pending transactions to hardware more frequently Chris Leech
2006-08-16  0:53 ` [PATCH 2/7] [I/OAT] Only offload copies for TCP when there will be a context switch Chris Leech
2006-08-16  0:53 ` [PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic Chris Leech
2006-08-18 18:17   ` Andi Kleen
2006-08-18 21:23     ` David Miller
2006-08-16  0:53 ` [PATCH 4/7] [I/OAT] Remove the wrappers around read(bwl)/write(bwl) in ioatdma Chris Leech
2006-08-18  0:05   ` I/OAT configuration ? Ravinandan Arakali
2006-08-16  0:53 ` Chris Leech [this message]
2006-08-16  0:53 ` [PATCH 6/7] [I/OAT] Add documentation for the tcp_dma_copybreak sysctl Chris Leech
2006-08-16  0:53 ` [PATCH 7/7] [I/OAT] Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma Chris Leech
2006-08-16  4:52   ` Randy.Dunlap
2006-08-16 16:57     ` [PATCH 7/7 v2] " Chris Leech
2006-08-18  7:11 ` [PATCH 1/7] [I/OAT] Push pending transactions to hardware more frequently Pavel Machek
2006-08-18 15:11   ` Chris Leech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060816005345.8634.53777.stgit@gitlost.site \
    --to=christopher.leech@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).